Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 931693002: Revert of Change g_webrtc_logging_delegate from process-level to RenderThread-level (Closed)

Created:
5 years, 10 months ago by tommi (sloooow) - chröme
Modified:
5 years, 10 months ago
Reviewers:
jinlong.zhai
CC:
dcheng, brettw, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Change g_webrtc_logging_delegate from process-level to RenderThread-level (patchset #1 id:1 of https://codereview.chromium.org/889313003/) Reason for revert: This breaks webrtc logging. It changes a global pointer to be a tls pointer, which doesn't work. Original issue's description: > Change g_webrtc_logging_delegate from process-level to RenderThread-level > > --single-process mode may happen crash in file of webrtc_logging.cc where code > is CHECK(!g_webrtc_logging_delegate). The orginal code is to expect there to > be only one g_webrtc_logging_delegate instance in a single render process. > g_webrtc_logging_delegate is created when a RenderThreadImpl is created. > But in --single-process model all RenderThreadImpl are created in browser > process and so g_webrtc_logging_delegate may be created many times in a single > process. Then CHECK(!g_webrtc_logging_delegate) will fail. > > In this patch will change g_webrtc_logging_delegate from process-level to > RenderThread-Level. Since every render process will only keep one RenderThread. > > BUG=455573 > > Committed: https://crrev.com/1fb332dc1f81bb05716342704b7f969af6921f3e > Cr-Commit-Position: refs/heads/master@{#315131} TBR=jinlong.zhai@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455573 Committed: https://crrev.com/d09e1d96a90e5a46e28a5cbb233feda986fa10d3 Cr-Commit-Position: refs/heads/master@{#316506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M AUTHORS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webrtc_logging.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommi (sloooow) - chröme
Created Revert of Change g_webrtc_logging_delegate from process-level to RenderThread-level
5 years, 10 months ago (2015-02-16 21:12:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931693002/1
5 years, 10 months ago (2015-02-16 21:13:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 21:13:56 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 21:14:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d09e1d96a90e5a46e28a5cbb233feda986fa10d3
Cr-Commit-Position: refs/heads/master@{#316506}

Powered by Google App Engine
This is Rietveld 408576698