Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 931333004: Add FrameNavigationEntry class. (Closed)

Created:
5 years, 10 months ago by Charlie Reis
Modified:
5 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FrameNavigationEntry class. This will be used to track session history items for subframes. For now, each NavigationEntry owns a single one for its main frame. BUG=236848 TEST=No behavior change. Committed: https://crrev.com/c415b9e7f1f8130b39e16f93a44cb5d0f27b1b02 Cr-Commit-Position: refs/heads/master@{#316943}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nits + git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -20 lines) Patch
A content/browser/frame_host/frame_navigation_entry.h View 1 1 chunk +64 lines, -0 lines 0 comments Download
A content/browser/frame_host/frame_navigation_entry.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.h View 3 chunks +8 lines, -6 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 5 chunks +12 lines, -14 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Charlie Reis
Avi: Let's get these changes going! Here's the first piece I've carved out from https://codereview.chromium.org/281653003/. ...
5 years, 10 months ago (2015-02-18 21:41:48 UTC) #2
Avi (use Gerrit)
That was simple enough. Only nits; LGTM with them fixed. https://codereview.chromium.org/931333004/diff/1/content/browser/frame_host/frame_navigation_entry.h File content/browser/frame_host/frame_navigation_entry.h (right): https://codereview.chromium.org/931333004/diff/1/content/browser/frame_host/frame_navigation_entry.h#newcode6 ...
5 years, 10 months ago (2015-02-18 21:56:24 UTC) #3
Charlie Reis
Thanks! I ran git cl format as well. https://codereview.chromium.org/931333004/diff/1/content/browser/frame_host/frame_navigation_entry.h File content/browser/frame_host/frame_navigation_entry.h (right): https://codereview.chromium.org/931333004/diff/1/content/browser/frame_host/frame_navigation_entry.h#newcode6 content/browser/frame_host/frame_navigation_entry.h:6: #define ...
5 years, 10 months ago (2015-02-18 22:04:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931333004/20001
5 years, 10 months ago (2015-02-18 22:06:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/34066)
5 years, 10 months ago (2015-02-18 23:30:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931333004/20001
5 years, 10 months ago (2015-02-18 23:41:24 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 01:06:39 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 01:07:54 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c415b9e7f1f8130b39e16f93a44cb5d0f27b1b02
Cr-Commit-Position: refs/heads/master@{#316943}

Powered by Google App Engine
This is Rietveld 408576698