Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(859)

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 931333004: Add FrameNavigationEntry class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nits + git cl format Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/navigation_entry_impl.h ('k') | content/content_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index 6869abd16612582f5dd4353d11726ecf228960c2..36ea59a1ed1988a60684179675d08ede1d011c09 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -48,12 +48,10 @@ NavigationEntryImpl::NavigationEntryImpl(SiteInstanceImpl* instance,
const base::string16& title,
ui::PageTransition transition_type,
bool is_renderer_initiated)
- : unique_id_(GetUniqueIDInConstructor()),
- site_instance_(instance),
+ : frame_entry_(instance, url, referrer),
+ unique_id_(GetUniqueIDInConstructor()),
bindings_(kInvalidBindings),
page_type_(PAGE_TYPE_NORMAL),
- url_(url),
- referrer_(referrer),
update_virtual_url_with_url_(false),
title_(title),
page_id_(page_id),
@@ -82,12 +80,12 @@ PageType NavigationEntryImpl::GetPageType() const {
}
void NavigationEntryImpl::SetURL(const GURL& url) {
- url_ = url;
+ frame_entry_.set_url(url);
cached_display_title_.clear();
}
const GURL& NavigationEntryImpl::GetURL() const {
- return url_;
+ return frame_entry_.url();
}
void NavigationEntryImpl::SetBaseURLForDataURL(const GURL& url) {
@@ -99,20 +97,20 @@ const GURL& NavigationEntryImpl::GetBaseURLForDataURL() const {
}
void NavigationEntryImpl::SetReferrer(const Referrer& referrer) {
- referrer_ = referrer;
+ frame_entry_.set_referrer(referrer);
}
const Referrer& NavigationEntryImpl::GetReferrer() const {
- return referrer_;
+ return frame_entry_.referrer();
}
void NavigationEntryImpl::SetVirtualURL(const GURL& url) {
- virtual_url_ = (url == url_) ? GURL() : url;
+ virtual_url_ = (url == GetURL()) ? GURL() : url;
cached_display_title_.clear();
}
const GURL& NavigationEntryImpl::GetVirtualURL() const {
- return virtual_url_.is_empty() ? url_ : virtual_url_;
+ return virtual_url_.is_empty() ? GetURL() : virtual_url_;
}
void NavigationEntryImpl::SetTitle(const base::string16& title) {
@@ -142,7 +140,7 @@ int32 NavigationEntryImpl::GetPageID() const {
}
void NavigationEntryImpl::set_site_instance(SiteInstanceImpl* site_instance) {
- site_instance_ = site_instance;
+ frame_entry_.set_site_instance(site_instance);
}
void NavigationEntryImpl::set_source_site_instance(
@@ -173,12 +171,12 @@ const base::string16& NavigationEntryImpl::GetTitleForDisplay(
base::string16 title;
if (!virtual_url_.is_empty()) {
title = net::FormatUrl(virtual_url_, languages);
- } else if (!url_.is_empty()) {
- title = net::FormatUrl(url_, languages);
+ } else if (!GetURL().is_empty()) {
+ title = net::FormatUrl(GetURL(), languages);
}
// For file:// URLs use the filename as the title, not the full path.
- if (url_.SchemeIsFile()) {
+ if (GetURL().SchemeIsFile()) {
base::string16::size_type slashpos = title.rfind('/');
if (slashpos != base::string16::npos)
title = title.substr(slashpos + 1);
« no previous file with comments | « content/browser/frame_host/navigation_entry_impl.h ('k') | content/content_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698