Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 931333003: Revert of Disallow wrapper creation from visitDOMWrapper (Closed)

Created:
5 years, 10 months ago by michaeln
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg, jsbell
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Disallow wrapper creation from visitDOMWrapper (patchset #3 id:40001 of https://codereview.chromium.org/931543002/) Reason for revert: Top crasher on canary with a very elevated crash rate. BUG=459312, 459086 Original issue's description: > Disallow wrapper creation from visitDOMWrapper > > visitDOMWrapper is called from during V8 GC, and it is not safe to create wrapper there, as it may lead to execution of arbitrary javascript while GC. > This CL removes the wrapper creation code from visitDOMWrapper template code, and replaces it with an ASSERT. > > BUG=None > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190231 TBR=haraken@chromium.org,kouhei@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M Source/bindings/templates/interface.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
michaeln
Created Revert of Disallow wrapper creation from visitDOMWrapper
5 years, 10 months ago (2015-02-17 23:08:56 UTC) #1
haraken
LGTM It makes sense to revert this at the moment, thanks!
5 years, 10 months ago (2015-02-17 23:13:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/931333003/1
5 years, 10 months ago (2015-02-17 23:22:21 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 23:22:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190364

Powered by Google App Engine
This is Rietveld 408576698