Issue 9310110: Coverity: Fix a pass-by-value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9310110: Coverity: Fix a pass-by-value. (Closed)

Created:
8 years, 10 months ago by James Hawkins

Modified:
8 years, 10 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Coverity: Fix a pass-by-value. CID=103258 BUG=none TEST=none R=groby Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120623

Patch Set 1 #

Total comments: 2

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/browser/content_settings/content_settings_observable_provider.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/content_settings/content_settings_observable_provider.cc	View		2 chunks	+5 lines, -5 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

lgtm http://codereview.chromium.org/9310110/diff/1/chrome/browser/content_settings/content_settings_observable_provider.cc File chrome/browser/content_settings/content_settings_observable_provider.cc (right): http://codereview.chromium.org/9310110/diff/1/chrome/browser/content_settings/content_settings_observable_provider.cc#newcode41 chrome/browser/content_settings/content_settings_observable_provider.cc:41: void ObservableProvider::RemoveAllObservers() { Just curious: Why move this?

8 years, 10 months ago (2012-02-06 18:40:42 UTC) #2

James Hawkins

8 years, 10 months ago (2012-02-06 21:29:15 UTC) #3

http://codereview.chromium.org/9310110/diff/1/chrome/browser/content_settings...
File chrome/browser/content_settings/content_settings_observable_provider.cc
(right):

http://codereview.chromium.org/9310110/diff/1/chrome/browser/content_settings...
chrome/browser/content_settings/content_settings_observable_provider.cc:41: void
ObservableProvider::RemoveAllObservers() {
On 2012/02/06 18:40:42, groby wrote:
> Just curious: Why move this?

To match the declaration order in the header.

Expand Messages | Collapse Messages