Coverity: Fix a pass-by-value.

chrome/browser/content_settings/content_settings_observable_provider.cc

Index: chrome/browser/content_settings/content_settings_observable_provider.cc
diff --git a/chrome/browser/content_settings/content_settings_observable_provider.cc b/chrome/browser/content_settings/content_settings_observable_provider.cc
index a175e74de35c4ea88e1b950d87639632a8dfa2f7..614d29aef413ed62f487e0641363ff9bfb3df59a 100644
--- a/chrome/browser/content_settings/content_settings_observable_provider.cc
+++ b/chrome/browser/content_settings/content_settings_observable_provider.cc
@@ -24,15 +24,11 @@ void ObservableProvider::RemoveObserver(Observer* observer) {
   observer_list_.RemoveObserver(observer);
 }
 
-void ObservableProvider::RemoveAllObservers() {
-  observer_list_.Clear();
-}
-
 void ObservableProvider::NotifyObservers(
     const ContentSettingsPattern& primary_pattern,
     const ContentSettingsPattern& secondary_pattern,
     ContentSettingsType content_type,
-    std::string resource_identifier) {
+    const std::string& resource_identifier) {
   FOR_EACH_OBSERVER(Observer,
                     observer_list_,
                     OnContentSettingChanged(
@@ -42,4 +38,8 @@ void ObservableProvider::NotifyObservers(
                         resource_identifier));
 }
 
+void ObservableProvider::RemoveAllObservers() {

[groby-ooo-7-16, 2012/02/06 18:40:42]

Just curious: Why move this?

[James Hawkins, 2012/02/06 21:29:15]

To match the declaration order in the header.

+  observer_list_.Clear();
+}
+
 }  // namespace content_settings