Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 9310063: When rethrowing an exception, print the stack trace of its original site instead of rethrow site. (Closed)

Created:
8 years, 10 months ago by Yang
Modified:
8 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

When rethrowing an exception, print the stack trace of its original site instead of rethrow site. BUG=60240 TEST=test-api/RethrowStackTrace

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -29 lines) Patch
M src/isolate.h View 3 chunks +7 lines, -2 lines 0 comments Download
M src/isolate.cc View 5 chunks +43 lines, -27 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
We now always capture a stack trace when throwing an exception and stash it away ...
8 years, 10 months ago (2012-02-02 16:02:48 UTC) #1
Vyacheslav Egorov (Chromium)
8 years, 10 months ago (2012-02-02 20:36:48 UTC) #2
Consider the difference in behavior between:

try {
  something_with_exception();
} catch (e) {
  throw e;
}

and 

try {
  something_with_exception();
} catch (e) {
  try { 
    something_with_exception();
  } catch (a) {
  }
  throw e;
}

Rethrown exceptions would have completely different stacktraces in this case.

Powered by Google App Engine
This is Rietveld 408576698