Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 930833003: Move and rename RenderReplaced and RenderHTMLCanvas to Layout{Replaced,HTMLCanvas}. (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
Reviewers:
dsinclair, dmazzoni
CC:
blink-reviews, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, krit, blink-reviews-css, blink-reviews-html_chromium.org, dglazkov+blink, jchaffraix+rendering, blink-reviews-paint_chromium.org, rwlbuis, zoltan1, philipj_slow, Dominik Röttsches, feature-media-reviews_chromium.org, gyuyoung.kim_webkit.org, darktears, blink-reviews-rendering, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move and rename RenderReplaced and RenderHTMLCanvas to Layout{Replaced,HTMLCanvas}. Also make LayoutReplaced::renderName() pure virtual. Everyone overrides it anyway. BUG=450612 TBR=dsinclair@chromium.org,dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190276

Patch Set 1 #

Patch Set 2 : No need to declare renderName() at all. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -1029 lines) Patch
M LayoutTests/compositing/render-surface-alpha-blending-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-render-layer-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/media/video-canvas-alpha-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/android/media/video-canvas-alpha-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/compositing/webgl/webgl-background-color-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/compositing/webgl/webgl-reflection-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/borders/border-radius-mask-canvas-border-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/borders/border-radius-mask-canvas-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/canvas/canvas-shadow-source-in-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/box-shadow-h-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/platform/linux/fast/repaint/box-shadow-v-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-shadow-source-in-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/threaded/compositing/webgl/webgl-background-color-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/threaded/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/threaded/compositing/webgl/webgl-reflection-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/compositing/webgl/webgl-background-color-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/compositing/webgl/webgl-reflection-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/borders/border-radius-mask-canvas-border-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/borders/border-radius-mask-canvas-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/canvas/canvas-shadow-source-in-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/repaint/box-shadow-h-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/platform/mac/fast/repaint/box-shadow-v-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/platform/mac/virtual/display_list_2d_canvas/fast/canvas/canvas-shadow-source-in-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-shadow-source-in-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/borders/border-radius-mask-canvas-border-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/borders/border-radius-mask-canvas-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/canvas/canvas-shadow-source-in-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/virtual/threaded/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/compositing/webgl/webgl-background-color-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/compositing/webgl/webgl-reflection-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/borders/border-radius-mask-canvas-border-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/borders/border-radius-mask-canvas-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/canvas/canvas-shadow-source-in-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/box-shadow-h-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/repaint/box-shadow-v-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/canvas-shadow-source-in-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/virtual/threaded/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/compositing/webgl/webgl-background-color-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/compositing/webgl/webgl-reflection-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/borders/border-radius-mask-canvas-border-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/borders/border-radius-mask-canvas-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/canvas/canvas-shadow-source-in-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/box-shadow-h-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/platform/win/fast/repaint/box-shadow-v-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-shadow-source-in-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/virtual/threaded/compositing/webgl/webgl-nonpremultiplied-blend-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/virtual/gpu/fast/canvas/canvas-render-layer-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/core.gypi View 4 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
A + Source/core/layout/LayoutHTMLCanvas.h View 1 chunk +9 lines, -9 lines 0 comments Download
A + Source/core/layout/LayoutHTMLCanvas.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M Source/core/layout/LayoutImage.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutImage.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
A + Source/core/layout/LayoutReplaced.h View 1 2 chunks +6 lines, -8 lines 0 comments Download
A + Source/core/layout/LayoutReplaced.cpp View 20 chunks +29 lines, -28 lines 0 comments Download
M Source/core/layout/LayoutVideo.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/paint/HTMLCanvasPainter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/paint/HTMLCanvasPainter.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/paint/ImagePainter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/ReplacedPainter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/paint/ReplacedPainter.cpp View 2 chunks +27 lines, -27 lines 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/rendering/RenderHTMLCanvas.h View 1 chunk +0 lines, -57 lines 0 comments Download
D Source/core/rendering/RenderHTMLCanvas.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
M Source/core/rendering/RenderPart.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderPart.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
D Source/core/rendering/RenderReplaced.h View 1 chunk +0 lines, -98 lines 0 comments Download
D Source/core/rendering/RenderReplaced.cpp View 1 chunk +0 lines, -511 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGRoot.cpp View 12 chunks +16 lines, -16 lines 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-16 19:23:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930833003/1
5 years, 10 months ago (2015-02-16 19:24:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930833003/20001
5 years, 10 months ago (2015-02-16 20:13:57 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 22:37:01 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190276

Powered by Google App Engine
This is Rietveld 408576698