Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 930763002: Revert of Fix getComputedStyle() for area element (Closed)

Created:
5 years, 10 months ago by tasak
Modified:
5 years, 10 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Fix getComputedStyle() for area element (patchset #11 id:380001 of https://codereview.chromium.org/442563002/) Reason for revert: This causes crbug.com/455253. Original issue's description: > Fix getComputedStyle() for area element > > The getComputedStyle() function didn't work as we expected for the area. > The reason is chrome set display area as none, this patch fix this problem. > > This behavior matches Firefox. > The Internet Explorer 11 set area display as none. > > BUG=392759 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180610 TBR=esprehn@chromium.org,ch.dumez@samsung.com,mahesh.kk@samsung.com,rob.buis@samsung.com,yosin@chromium.org,zhaoze.zhou@partner.samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=392759

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -422 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -28 lines 0 comments Download
M LayoutTests/accessibility/image-map1.html View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/accessibility/image-map1-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M LayoutTests/accessibility/image-map2-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/css/area-computedStyle.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/css/area-computedStyle-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-case-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-circle-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-focus-ring-outline-color-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-focus-ring-zoom-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-overflowing-circle-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-overflowing-polygon-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/images/imagemap-polygon-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/http/tests/misc/acid3-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1296-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug1430-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-case-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-overflowing-circle-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-overflowing-polygon-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/fast/images/imagemap-case-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
M LayoutTests/platform/mac/fast/images/imagemap-circle-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/fast/images/imagemap-focus-ring-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M LayoutTests/platform/mac/fast/images/imagemap-focus-ring-outline-color-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M LayoutTests/platform/mac/fast/images/imagemap-focus-ring-zoom-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/images/imagemap-overflowing-circle-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/images/imagemap-overflowing-polygon-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/images/imagemap-polygon-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/http/tests/misc/acid3-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/tables/mozilla/bugs/bug1296-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/mac/tables/mozilla/bugs/bug1430-expected.txt View 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-case-expected.txt View 1 chunk +0 lines, -28 lines 0 comments Download
M LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-circle-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-focus-ring-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-focus-ring-zoom-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-overflowing-circle-focus-ring-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-overflowing-polygon-focus-ring-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
M LayoutTests/platform/mac/virtual/deferred/fast/images/imagemap-polygon-focus-ring-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/html.css View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tasak
Created Revert of Fix getComputedStyle() for area element
5 years, 10 months ago (2015-02-16 06:12:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930763002/1
5 years, 10 months ago (2015-02-16 06:12:40 UTC) #2
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 06:13:14 UTC) #4
Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1299.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
2ec8b023bf45fc34b42bb89fcef86d42d5ec0204..4ff133a93087e36213903e5f7c3ea0e5bef786cd
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1299,31 +1299,3 @@
 crbug.com/402379 [ Win7 Debug ] storage/indexeddb/mozilla/indexes.html [ Pass
Slow ]
 
 crbug.com/402801 [ XP Release ]
http/tests/misc/location-replace-crossdomain.html [ Pass Slow ]
-
-crbug.com/388780 fast/dom/geometry-interfaces-dom-matrix-translate.html [
NeedsRebaseline ]
-crbug.com/388780 fast/dom/geometry-interfaces-dom-matrix-scale.html [
NeedsRebaseline ]
-
-crbug.com/392759 [ Win ] fast/images/imagemap-case.html [ NeedsRebaseline ]
-crbug.com/392759 [ Win ] fast/images/imagemap-circle-focus-ring.html [
NeedsRebaseline ]
-crbug.com/392759 [ Win ]
fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html
[ NeedsRebaseline ]
-crbug.com/392759 [ Win ]
fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html [
NeedsRebaseline ]
-crbug.com/392759 [ Win ] fast/images/imagemap-focus-ring-outline-color.html [
NeedsRebaseline ]
-crbug.com/392759 [ Win ]
fast/images/imagemap-focus-ring-zero-outline-width.html [ NeedsRebaseline ]
-crbug.com/392759 [ Win ] fast/images/imagemap-focus-ring-zoom.html [
NeedsRebaseline ]
-crbug.com/392759 [ Win ] fast/images/imagemap-focus-ring.html [ NeedsRebaseline
]
-crbug.com/392759 [ Win ]
fast/images/imagemap-overflowing-circle-focus-ring.html [ NeedsRebaseline ]
-crbug.com/392759 [ Win ]
fast/images/imagemap-overflowing-polygon-focus-ring.html [ NeedsRebaseline ]
-crbug.com/392759 [ Win ] fast/images/imagemap-polygon-focus-ring.html [
NeedsRebaseline ]
-crbug.com/392759 [ Win ] tables/mozilla/bugs/bug1296.html [ NeedsRebaseline ]
-crbug.com/392759 [ Win ] tables/mozilla/bugs/bug1430.html [ NeedsRebaseline ]
-crbug.com/392759 [ Win ] virtual/deferred/fast/images/imagemap-case.html [
NeedsRebaseline ]
-crbug.com/392759 [ Win ]
virtual/deferred/fast/images/imagemap-circle-focus-ring.html [ NeedsRebaseline ]
-crbug.com/392759 [ Win ]
virtual/deferred/fast/images/imagemap-focus-ring-outline-color-explicitly-inherited-from-map.html
[ NeedsRebaseline ]
-crbug.com/392759 [ Win ]
virtual/deferred/fast/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html
[ NeedsRebaseline ]
-crbug.com/392759 [ Win ]
virtual/deferred/fast/images/imagemap-focus-ring-outline-color.html [
NeedsRebaseline ]
-crbug.com/392759 [ Win ]
virtual/deferred/fast/images/imagemap-focus-ring-zero-outline-width.html [
NeedsRebaseline ]
-crbug.com/392759 [ Win ]
virtual/deferred/fast/images/imagemap-focus-ring-zoom.html [ NeedsRebaseline ]
-crbug.com/392759 [ Win ] virtual/deferred/fast/images/imagemap-focus-ring.html
[ NeedsRebaseline ]
-crbug.com/392759 [ Win ]
virtual/deferred/fast/images/imagemap-overflowing-circle-focus-ring.html [
NeedsRebaseline ]
-crbug.com/392759 [ Win ]
virtual/deferred/fast/images/imagemap-overflowing-polygon-focus-ring.html [
NeedsRebaseline ]
-crbug.com/392759 [ Win ]
virtual/deferred/fast/images/imagemap-polygon-focus-ring.html [ NeedsRebaseline
]

Powered by Google App Engine
This is Rietveld 408576698