Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 930053002: Apply TypeChecking=Unrestricted to SVG{Number,Length,Transform,Angle} (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
CC:
blink-reviews, shans, vivekg_samsung, fs, vivekg, kouhei+svg_chromium.org, rwlbuis, krit, arv+blink, dstockwell, Timothy Loh, pdr+svgwatchlist_chromium.org, Eric Willigers, Steve Block, rjwright, gyuyoung.kim_webkit.org, darktears, blink-reviews-animation_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Apply TypeChecking=Unrestricted to SVG{Number,Length,Transform,Angle} Matches Gecko. BUG=354298, 311246 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190303

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -135 lines) Patch
M LayoutTests/svg/dom/SVGAngle-expected.txt View 2 chunks +33 lines, -21 lines 0 comments Download
M LayoutTests/svg/dom/SVGAnimatedNumber-expected.txt View 1 chunk +8 lines, -4 lines 0 comments Download
M LayoutTests/svg/dom/SVGLength-expected.txt View 2 chunks +27 lines, -10 lines 0 comments Download
M LayoutTests/svg/dom/SVGNumber-expected.txt View 1 chunk +7 lines, -4 lines 0 comments Download
M LayoutTests/svg/dom/SVGTransform-expected.txt View 2 chunks +45 lines, -27 lines 0 comments Download
M LayoutTests/svg/dom/script-tests/SVGAngle.js View 2 chunks +30 lines, -18 lines 0 comments Download
M LayoutTests/svg/dom/script-tests/SVGAnimatedNumber.js View 1 chunk +8 lines, -4 lines 0 comments Download
M LayoutTests/svg/dom/script-tests/SVGLength.js View 2 chunks +26 lines, -7 lines 0 comments Download
M LayoutTests/svg/dom/script-tests/SVGNumber.js View 1 chunk +7 lines, -4 lines 0 comments Download
M LayoutTests/svg/dom/script-tests/SVGTransform.js View 3 chunks +45 lines, -27 lines 0 comments Download
M Source/core/svg/SVGAngle.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimatedNumber.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/svg/SVGLength.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGNumber.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTransform.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
5 years, 10 months ago (2015-02-16 15:46:17 UTC) #2
Erik Dahlström (inactive)
lgtm
5 years, 10 months ago (2015-02-16 16:13:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/930053002/1
5 years, 10 months ago (2015-02-17 10:28:12 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 10:32:10 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190303

Powered by Google App Engine
This is Rietveld 408576698