Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: LayoutTests/svg/dom/script-tests/SVGTransform.js

Issue 930053002: Apply TypeChecking=Unrestricted to SVG{Number,Length,Transform,Angle} (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/svg/dom/script-tests/SVGNumber.js ('k') | Source/core/svg/SVGAngle.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/svg/dom/script-tests/SVGTransform.js
diff --git a/LayoutTests/svg/dom/script-tests/SVGTransform.js b/LayoutTests/svg/dom/script-tests/SVGTransform.js
index 18c4b5fbdc2fb3511d4939d65a27345dfdb89342..4e02b64ba6ed49a9e1c707f06d42ee4adade57c9 100644
--- a/LayoutTests/svg/dom/script-tests/SVGTransform.js
+++ b/LayoutTests/svg/dom/script-tests/SVGTransform.js
@@ -66,15 +66,19 @@ shouldThrow("transform.setTranslate()");
shouldThrow("transform.setTranslate(transform)");
shouldThrow("transform.setTranslate(svgElement)");
shouldThrow("transform.setTranslate('aString')");
-shouldBeUndefined("transform.setTranslate(1, transform)");
-shouldBeUndefined("transform.setTranslate(1, svgElement)");
-shouldBeUndefined("transform.setTranslate(1, 'aString')");
-shouldBeUndefined("transform.setTranslate(transform, 1)");
-shouldBeUndefined("transform.setTranslate(svgElement, 1)");
-shouldBeUndefined("transform.setTranslate('aString', 1)");
-shouldBeUndefined("transform.setTranslate(transform, transform)");
-shouldBeUndefined("transform.setTranslate(svgElement, svgElement)");
-shouldBeUndefined("transform.setTranslate('aString', 'aString')");
+shouldThrow("transform.setTranslate(1, transform)");
+shouldThrow("transform.setTranslate(1, svgElement)");
+shouldThrow("transform.setTranslate(1, 'aString')");
+shouldThrow("transform.setTranslate(transform, 1)");
+shouldThrow("transform.setTranslate(svgElement, 1)");
+shouldThrow("transform.setTranslate('aString', 1)");
+shouldThrow("transform.setTranslate(transform, transform)");
+shouldThrow("transform.setTranslate(svgElement, svgElement)");
+shouldThrow("transform.setTranslate('aString', 'aString')");
+shouldThrow("transform.setTranslate(NaN, 1)");
+shouldThrow("transform.setTranslate(Infinity, 1)");
+shouldThrow("transform.setTranslate(1, NaN)");
+shouldThrow("transform.setTranslate(1, Infinity)");
debug("");
debug("Check passing invalid arguments to 'setScale'");
@@ -82,15 +86,19 @@ shouldThrow("transform.setScale()");
shouldThrow("transform.setScale(transform)");
shouldThrow("transform.setScale(svgElement)");
shouldThrow("transform.setScale('aString')");
-shouldBeUndefined("transform.setScale(1, transform)");
-shouldBeUndefined("transform.setScale(1, svgElement)");
-shouldBeUndefined("transform.setScale(1, 'aString')");
-shouldBeUndefined("transform.setScale(transform, 1)");
-shouldBeUndefined("transform.setScale(svgElement, 1)");
-shouldBeUndefined("transform.setScale('aString', 1)");
-shouldBeUndefined("transform.setScale(transform, transform)");
-shouldBeUndefined("transform.setScale(svgElement, svgElement)");
-shouldBeUndefined("transform.setScale('aString', 'aString')");
+shouldThrow("transform.setScale(1, transform)");
+shouldThrow("transform.setScale(1, svgElement)");
+shouldThrow("transform.setScale(1, 'aString')");
+shouldThrow("transform.setScale(transform, 1)");
+shouldThrow("transform.setScale(svgElement, 1)");
+shouldThrow("transform.setScale('aString', 1)");
+shouldThrow("transform.setScale(transform, transform)");
+shouldThrow("transform.setScale(svgElement, svgElement)");
+shouldThrow("transform.setScale('aString', 'aString')");
+shouldThrow("transform.setScale(NaN, 1)");
+shouldThrow("transform.setScale(Infinity, 1)");
+shouldThrow("transform.setScale(1, NaN)");
+shouldThrow("transform.setScale(1, Infinity)");
debug("");
debug("Check passing invalid arguments to 'setRotate'");
@@ -101,22 +109,32 @@ shouldThrow("transform.setRotate('aString')");
shouldThrow("transform.setRotate(1, transform)");
shouldThrow("transform.setRotate(1, svgElement)");
shouldThrow("transform.setRotate(1, 'aString')");
-shouldBeUndefined("transform.setRotate(1, 1, transform)");
-shouldBeUndefined("transform.setRotate(1, 1, svgElement)");
-shouldBeUndefined("transform.setRotate(1, 1, 'aString')");
+shouldThrow("transform.setRotate(1, 1, transform)");
+shouldThrow("transform.setRotate(1, 1, svgElement)");
+shouldThrow("transform.setRotate(1, 1, 'aString')");
+shouldThrow("transform.setRotate(NaN, 1, 1)");
+shouldThrow("transform.setRotate(Infinity, 1, 1)");
+shouldThrow("transform.setRotate(1, NaN, 1)");
+shouldThrow("transform.setRotate(1, Infinity, 1)");
+shouldThrow("transform.setRotate(1, 1, NaN)");
+shouldThrow("transform.setRotate(1, 1, Infinity)");
debug("");
debug("Check passing invalid arguments to 'setSkewX'");
shouldThrow("transform.setSkewX()");
-shouldBeUndefined("transform.setSkewX(transform)");
-shouldBeUndefined("transform.setSkewX(svgElement)");
-shouldBeUndefined("transform.setSkewX('aString')");
+shouldThrow("transform.setSkewX(transform)");
+shouldThrow("transform.setSkewX(svgElement)");
+shouldThrow("transform.setSkewX('aString')");
+shouldThrow("transform.setSkewX(NaN)");
+shouldThrow("transform.setSkewX(Infinity)");
debug("");
debug("Check passing invalid arguments to 'setSkewY'");
shouldThrow("transform.setSkewY()");
-shouldBeUndefined("transform.setSkewY(transform)");
-shouldBeUndefined("transform.setSkewY(svgElement)");
-shouldBeUndefined("transform.setSkewY('aString')");
+shouldThrow("transform.setSkewY(transform)");
+shouldThrow("transform.setSkewY(svgElement)");
+shouldThrow("transform.setSkewY('aString')");
+shouldThrow("transform.setSkewY(NaN)");
+shouldThrow("transform.setSkewY(Infinity)");
successfullyParsed = true;
« no previous file with comments | « LayoutTests/svg/dom/script-tests/SVGNumber.js ('k') | Source/core/svg/SVGAngle.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698