Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: third_party/cld/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/cld/BUILD.gn
diff --git a/third_party/cld/BUILD.gn b/third_party/cld/BUILD.gn
index ed4075d2bb8a2972c73f8b5cf5b401dfa3d5846e..2d986114675bcf426c0fc02ce8651f89e81b4dcf 100644
--- a/third_party/cld/BUILD.gn
+++ b/third_party/cld/BUILD.gn
@@ -93,7 +93,11 @@ source_set("cld") {
"//build/config/compiler:default_include_dirs",
"//build/config/compiler:chromium_code",
]
- configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [
+ "//build/config/compiler:no_chromium_code",
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ "//build/config/compiler:no_size_t_to_int_warning",
Dirk Pranke 2015/02/18 21:29:29 same comment about no_size_t being already part of
+ ]
public_configs = [ ":cld_config" ]
if (is_win) {
@@ -102,7 +106,6 @@ source_set("cld") {
"/wd4005", # Macro defined twice.
"/wd4006", # #undef expected an identifier.
"/wd4309", # Truncation of constant value.
- "/wd4267", # TODO(jschuh): C4267: http://crbug.com/167187 size_t -> int
]
} else {
defines = [ "COMPILER_GCC" ]

Powered by Google App Engine
This is Rietveld 408576698