Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: storage/common/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/third_party/nss/ssl/BUILD.gn ('K') | « storage/browser/BUILD.gn ('k') | third_party/boringssl/BUILD.gn » ('j') | third_party/cld/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: storage/common/BUILD.gn
diff --git a/storage/common/BUILD.gn b/storage/common/BUILD.gn
index 00679727aabd8a076d017a66572791dc2cf20f23..2c55bb9eac92e50a63701c1314c91124b9de32cc 100644
--- a/storage/common/BUILD.gn
+++ b/storage/common/BUILD.gn
@@ -26,10 +26,10 @@ component("common") {
"quota/quota_types.h",
]
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
defines = [ "STORAGE_COMMON_IMPLEMENTATION" ]
- if (is_win) {
- cflags = [ "/wd4267" ] # TODO(jschuh): fix size_t to int truncations.
- }
deps = [
"//base",
« net/third_party/nss/ssl/BUILD.gn ('K') | « storage/browser/BUILD.gn ('k') | third_party/boringssl/BUILD.gn » ('j') | third_party/cld/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698