Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc

Issue 929523002: Add tests to EnhancedBookmarksModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
diff --git a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
index ba6b942379e4ccfda1d75e40ba32d93dce2eb316..fbbdbda57339952ff69e9015ebc9120ed2e823de 100644
--- a/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
+++ b/chrome/browser/enhanced_bookmarks/android/enhanced_bookmarks_bridge.cc
@@ -204,8 +204,8 @@ ScopedJavaLocalRef<jobject> EnhancedBookmarksBridge::AddFolder(JNIEnv* env,
NOTREACHED();
return ScopedJavaLocalRef<jobject>();
}
- ScopedJavaLocalRef<jobject> new_java_obj =
- JavaBookmarkIdCreateBookmarkId(env, new_node->id(), new_node->type());
+ ScopedJavaLocalRef<jobject> new_java_obj = JavaBookmarkIdCreateBookmarkId(
+ env, new_node->id(), BookmarkType::BOOKMARK_TYPE_NORMAL);
Kibeom Kim (inactive) 2015/02/13 23:26:26 Since this should be merged, wouldn't it be easier
Ian Wen 2015/02/13 23:56:43 crbug.com/458703 I will have a specific CL on M41.
return new_java_obj;
}
@@ -255,8 +255,8 @@ ScopedJavaLocalRef<jobject> EnhancedBookmarksBridge::AddBookmark(
NOTREACHED();
return ScopedJavaLocalRef<jobject>();
}
- ScopedJavaLocalRef<jobject> new_java_obj =
- JavaBookmarkIdCreateBookmarkId(env, new_node->id(), new_node->type());
+ ScopedJavaLocalRef<jobject> new_java_obj = JavaBookmarkIdCreateBookmarkId(
+ env, new_node->id(), BookmarkType::BOOKMARK_TYPE_NORMAL);
return new_java_obj;
}

Powered by Google App Engine
This is Rietveld 408576698