Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java

Issue 929523002: Add tests to EnhancedBookmarksModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
index 93140596c518a1c38c63c3b6afe4217ff7856c78..b69da8936c8db0265e4e0351e6be8b7737c94c56 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
@@ -472,16 +472,6 @@ public class BookmarksBridge {
}
/**
- * Move the bookmark to the new index within same folder or to a different folder.
- * @param bookmarkId The id of the bookmark that is being moved.
- * @param newParentId The parent folder id.
- * @param index The new index for the bookmark.
- */
- public void moveBookmark(BookmarkId bookmarkId, BookmarkId newParentId, int index) {
- nativeMoveBookmark(mNativeBookmarksBridge, bookmarkId, newParentId, index);
- }
-
- /**
* Add a new folder to the given parent folder
*
* @param parent Folder where to add. Must be a normal editable folder, instead of a partner
@@ -492,6 +482,7 @@ public class BookmarksBridge {
* @return Id of the added node. If adding failed (index is invalid, string is null, parent is
* not editable), returns null.
*/
+ @VisibleForTesting
public BookmarkId addFolder(BookmarkId parent, int index, String title) {
Ian Wen 2015/02/13 23:56:43 These two functions are only used in SigninTest. M
assert parent.getType() == BookmarkType.NORMAL;
assert index >= 0;
@@ -512,6 +503,7 @@ public class BookmarksBridge {
* @return Id of the added node. If adding failed (index is invalid, string is null, parent is
* not editable), returns null.
*/
+ @VisibleForTesting
public BookmarkId addBookmark(BookmarkId parent, int index, String title, String url) {
assert parent.getType() == BookmarkType.NORMAL;
assert index >= 0;

Powered by Google App Engine
This is Rietveld 408576698