Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(917)

Issue 929393003: Rename some postmessage API to make it more meaningful. (Closed)

Created:
5 years, 10 months ago by sgurun-gerrit only
Modified:
5 years, 10 months ago
Reviewers:
hush (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename some postmessage API to make it more meaningful. BUG=393291 Committed: https://crrev.com/f9dbeb215e44d6f46e8fa395d1a6bb114a9752bf Cr-Commit-Position: refs/heads/master@{#316980}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M android_webview/java/src/org/chromium/android_webview/MessagePort.java View 1 4 chunks +8 lines, -8 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sgurun-gerrit only
On 2015/02/19 01:48:27, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:hush@chromium.org PTAL, thanks
5 years, 10 months ago (2015-02-19 01:48:34 UTC) #2
hush (inactive)
https://codereview.chromium.org/929393003/diff/1/android_webview/java/src/org/chromium/android_webview/MessagePort.java File android_webview/java/src/org/chromium/android_webview/MessagePort.java (right): https://codereview.chromium.org/929393003/diff/1/android_webview/java/src/org/chromium/android_webview/MessagePort.java#newcode43 android_webview/java/src/org/chromium/android_webview/MessagePort.java:43: public abstract static class WebEventHandler { WebEvent implies there ...
5 years, 10 months ago (2015-02-19 02:05:24 UTC) #3
sgurun-gerrit only
https://codereview.chromium.org/929393003/diff/1/android_webview/java/src/org/chromium/android_webview/MessagePort.java File android_webview/java/src/org/chromium/android_webview/MessagePort.java (right): https://codereview.chromium.org/929393003/diff/1/android_webview/java/src/org/chromium/android_webview/MessagePort.java#newcode43 android_webview/java/src/org/chromium/android_webview/MessagePort.java:43: public abstract static class WebEventHandler { On 2015/02/19 02:05:24, ...
5 years, 10 months ago (2015-02-19 02:30:36 UTC) #4
hush (inactive)
lgtm
5 years, 10 months ago (2015-02-19 02:31:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929393003/20001
5 years, 10 months ago (2015-02-19 02:32:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 02:52:15 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 02:52:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9dbeb215e44d6f46e8fa395d1a6bb114a9752bf
Cr-Commit-Position: refs/heads/master@{#316980}

Powered by Google App Engine
This is Rietveld 408576698