Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2280)

Unified Diff: android_webview/java/src/org/chromium/android_webview/MessagePort.java

Issue 929393003: Rename some postmessage API to make it more meaningful. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address code review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/java/src/org/chromium/android_webview/MessagePort.java
diff --git a/android_webview/java/src/org/chromium/android_webview/MessagePort.java b/android_webview/java/src/org/chromium/android_webview/MessagePort.java
index f909056d82294588d50d18683ae0da85be28ea87..2d0e3939d6f3b61ab6188591edce912b598008a3 100644
--- a/android_webview/java/src/org/chromium/android_webview/MessagePort.java
+++ b/android_webview/java/src/org/chromium/android_webview/MessagePort.java
@@ -37,10 +37,10 @@ import android.util.Log;
public class MessagePort implements PostMessageSender.PostMessageSenderDelegate {
/**
- * The interface for message handler for receiving messages. Called on a background thread.
+ * The message event handler for receiving messages. Called on a background thread.
*/
- public static interface MessageHandler {
- void onMessage(String message);
+ public abstract static class WebEventHandler {
+ public abstract void onMessage(String message);
};
/**
@@ -63,7 +63,7 @@ public class MessagePort implements PostMessageSender.PostMessageSenderDelegate
private static final String TAG = "MessagePort";
private static final int PENDING = -1;
private int mPortId = PENDING;
- private MessageHandler mHandler;
+ private WebEventHandler mWebEventHandler;
private AwMessagePortService mMessagePortService;
private boolean mClosed;
private boolean mTransferred;
@@ -108,8 +108,8 @@ public class MessagePort implements PostMessageSender.PostMessageSenderDelegate
mTransferred = true;
}
- public void setMessageHandler(MessageHandler handler) {
- mHandler = handler;
+ public void setWebEventHandler(WebEventHandler webEventHandler) {
+ mWebEventHandler = webEventHandler;
}
public void onMessage(String message) {
@@ -117,11 +117,11 @@ public class MessagePort implements PostMessageSender.PostMessageSenderDelegate
Log.w(TAG, "Port [" + mPortId + "] received message in closed state");
return;
}
- if (mHandler == null) {
+ if (mWebEventHandler == null) {
Log.w(TAG, "No handler set for port [" + mPortId + "], dropping message " + message);
return;
}
- mHandler.onMessage(message);
+ mWebEventHandler.onMessage(message);
}
public void postMessage(String message, MessagePort[] msgPorts) throws IllegalStateException {
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698