Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 929273002: Use IDL union for Timing.duration (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
dstockwell, Timothy Loh
CC:
dstockwell, darktears, arv+blink, blink-reviews, blink-reviews-animation_chromium.org, Inactive, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh, vivekg_samsung, vivekg
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use IDL union for Timing.duration Replace the named setter/getter hack with a proper union attribute. This fixes the behavior when assigning a DOMString that can be interpreted as a number, so adjust (fix) test. BUG=430337, 335350 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -37 lines) Patch
M LayoutTests/web-animations-api/timed-item-specified-setters.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimationNodeTiming.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/animation/AnimationNodeTiming.cpp View 2 chunks +7 lines, -18 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M Source/core/animation/Timing.idl View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 10 months ago (2015-02-17 12:52:30 UTC) #2
Timothy Loh
lgtm
5 years, 10 months ago (2015-02-17 23:12:19 UTC) #3
dstockwell
lgtm
5 years, 10 months ago (2015-02-18 02:40:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/929273002/1
5 years, 10 months ago (2015-02-18 02:41:34 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 02:44:38 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190376

Powered by Google App Engine
This is Rietveld 408576698