Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: Source/core/animation/AnimationTest.cpp

Issue 929273002: Use IDL union for Timing.duration (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/AnimationNodeTiming.cpp ('k') | Source/core/animation/Timing.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/AnimationTest.cpp
diff --git a/Source/core/animation/AnimationTest.cpp b/Source/core/animation/AnimationTest.cpp
index 7407759b317d5d438ad0ae1906e31cb4ccdc9bb0..bec3991246e5e82de907eb3518fabf6c2a2414b7 100644
--- a/Source/core/animation/AnimationTest.cpp
+++ b/Source/core/animation/AnimationTest.cpp
@@ -255,7 +255,7 @@ TEST_F(AnimationAnimationV8Test, SpecifiedDurationGetter)
RefPtrWillBeRawPtr<AnimationNodeTiming> specifiedWithDuration = animationWithDuration->timing();
DoubleOrString duration;
- specifiedWithDuration->getDuration("duration", duration);
+ specifiedWithDuration->duration(duration);
EXPECT_TRUE(duration.isDouble());
EXPECT_EQ(2.5, duration.getAsDouble());
EXPECT_FALSE(duration.isString());
@@ -268,7 +268,7 @@ TEST_F(AnimationAnimationV8Test, SpecifiedDurationGetter)
RefPtrWillBeRawPtr<AnimationNodeTiming> specifiedNoDuration = animationNoDuration->timing();
DoubleOrString duration2;
- specifiedNoDuration->getDuration("duration", duration2);
+ specifiedNoDuration->duration(duration2);
EXPECT_FALSE(duration2.isDouble());
EXPECT_TRUE(duration2.isString());
EXPECT_EQ("auto", duration2.getAsString());
@@ -326,14 +326,16 @@ TEST_F(AnimationAnimationV8Test, SetSpecifiedDuration)
RefPtrWillBeRawPtr<AnimationNodeTiming> specified = animation->timing();
DoubleOrString duration;
- specified->getDuration("duration", duration);
+ specified->duration(duration);
EXPECT_FALSE(duration.isDouble());
EXPECT_TRUE(duration.isString());
EXPECT_EQ("auto", duration.getAsString());
- specified->setDuration("duration", 2.5);
+ DoubleOrString inDuration;
+ inDuration.setDouble(2.5);
+ specified->setDuration(inDuration);
DoubleOrString duration2;
- specified->getDuration("duration", duration2);
+ specified->duration(duration2);
EXPECT_TRUE(duration2.isDouble());
EXPECT_EQ(2.5, duration2.getAsDouble());
EXPECT_FALSE(duration2.isString());
« no previous file with comments | « Source/core/animation/AnimationNodeTiming.cpp ('k') | Source/core/animation/Timing.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698