Fixed several pylint warnings on Windows.

Fixed several pylint warnings on Windows.

Committed: https://crrev.com/a0f67e034ea83f64ba12240176cd6fdd0ac8b878
Cr-Commit-Position: refs/heads/master@{#316527}

[Yoshisato Yanagisawa, 2015-02-17 01:32:24]

yyanagisawa@chromium.org changed reviewers:
+ brettw@chromium.org, scottmg@chromium.org

[Yoshisato Yanagisawa, 2015-02-17 01:32:25]

Hi,

I found several lint warnings in the python scripts.  I use the copy of the
scripts in our project, and often see pylint warnings, which we usually do not
allow.

Can I ask you to review them?
Thank you in advance,

[scottmg, 2015-02-17 02:51:56]

lgtm

https://codereview.chromium.org/929183002/diff/20001/build/toolchain/get_conc...
File build/toolchain/get_concurrent_links.py (right):

https://codereview.chromium.org/929183002/diff/20001/build/toolchain/get_conc...
build/toolchain/get_concurrent_links.py:59: sys.stderr.write(inst)
I think this should probably stay silent. Does pylint require something to be
done with |inst|?

https://codereview.chromium.org/929183002/diff/20001/build/toolchain/win/setu...
File build/toolchain/win/setup_toolchain.py (right):

https://codereview.chromium.org/929183002/diff/20001/build/toolchain/win/setu...
build/toolchain/win/setup_toolchain.py:105: dummy_vs_path = sys.argv[1]
I think just delete this line is fine. Someone will need to readd when we get
this working properly.

[Yoshisato Yanagisawa, 2015-02-17 03:39:35]

Thanks for the review.

https://codereview.chromium.org/929183002/diff/20001/build/toolchain/get_conc...
File build/toolchain/get_concurrent_links.py (right):

https://codereview.chromium.org/929183002/diff/20001/build/toolchain/get_conc...
build/toolchain/get_concurrent_links.py:59: sys.stderr.write(inst)
No.  Non-silent is just my preference.
Seeing the script again, and I agree with your opinion.

https://codereview.chromium.org/929183002/diff/20001/build/toolchain/win/setu...
File build/toolchain/win/setup_toolchain.py (right):

https://codereview.chromium.org/929183002/diff/20001/build/toolchain/win/setu...
build/toolchain/win/setup_toolchain.py:105: dummy_vs_path = sys.argv[1]
On 2015/02/17 02:51:56, scottmg wrote:
> I think just delete this line is fine. Someone will need to readd when we get
> this working properly.

Done.

[Yoshisato Yanagisawa, 2015-02-17 03:40:46]

New patchsets have been uploaded after l-g-t-m from scottmg@chromium.org

[Yoshisato Yanagisawa, 2015-02-17 03:41:41]

The CQ bit was checked by yyanagisawa@chromium.org

[commit-bot: I haz the power, 2015-02-17 03:42:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/929183002/40001

[commit-bot: I haz the power, 2015-02-17 04:02:27]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-17 04:02:59]

Patchset 3 (id:??) landed as
https://crrev.com/a0f67e034ea83f64ba12240176cd6fdd0ac8b878
Cr-Commit-Position: refs/heads/master@{#316527}