build/vs_toolchain.py - Issue 929183002: Fixed several pylint warnings on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/vs_toolchain.py

Issue 929183002: Fixed several pylint warnings on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: silent on mac sysctl error, ignore vs_path Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/vs_toolchain.py

diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py

index 5373f03e578a718ef49cf3d84d3975b687327114..6f49e7c2e8e01692842537b0471b3583ae2a8c66 100644

--- a/build/vs_toolchain.py

+++ b/build/vs_toolchain.py

@@ -37,7 +37,6 @@ def SetEnvironmentAndGetRuntimeDllDirs():

toolchain = toolchain_data['path']

version = toolchain_data['version']

- version_is_pro = version[-1] != 'e'

win8sdk = toolchain_data['win8sdk']

wdk = toolchain_data['wdk']

# TODO(scottmg): The order unfortunately matters in these. They should be

@@ -168,7 +167,6 @@ def Update():

if sys.platform in ('win32', 'cygwin') and depot_tools_win_toolchain:

import find_depot_tools

depot_tools_path = find_depot_tools.add_depot_tools_to_path()

- json_data_file = os.path.join(script_dir, 'win_toolchain.json')

get_toolchain_args = [

sys.executable,

os.path.join(depot_tools_path,

« no previous file with comments | « build/toolchain/win/setup_toolchain.py ('k') | no next file » | no next file with comments »