ui/events/keycodes/keyboard_code_conversion.cc - Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/keycodes/keyboard_code_conversion.cc

Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: UnitTest updated as MakeKeyboardEvent now adds a value to differentiate Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/events/keycodes/keyboard_code_conversion.cc

diff --git a/ui/events/keycodes/keyboard_code_conversion.cc b/ui/events/keycodes/keyboard_code_conversion.cc

index 7494ffa93db79418411021c030430686a0b43460..c0de3fb8f818ae20008670bb7b53556c6eeb97e4 100644

--- a/ui/events/keycodes/keyboard_code_conversion.cc

+++ b/ui/events/keycodes/keyboard_code_conversion.cc

@@ -18,7 +18,7 @@ namespace {

// This table maps a subset of |KeyboardCode| (VKEYs) to DomKey and character.

// Only values not otherwise handled by GetMeaningFromKeyCode() are here.

const struct KeyboardCodeToMeaning {

- KeyboardCode key_code;

+ ui::KeyboardCode key_code;

Wez 2015/07/25 23:12:26 ?

Habib Virji 2015/07/31 16:17:29 Removed

DomKey key;

base::char16 plain_character;

base::char16 shift_character;

« ui/events/keycodes/dom_us_layout_data.h ('K') | « ui/events/keycodes/dom_us_layout_data.h ('k') | no next file » | no next file with comments »