ui/events/keycodes/dom_us_layout_data.h - Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/keycodes/dom_us_layout_data.h

Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: UnitTest updated as MakeKeyboardEvent now adds a value to differentiate Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/events/keycodes/dom/dom_key.h ('K') | « ui/events/keycodes/dom/dom_key.h ('k') | ui/events/keycodes/keyboard_code_conversion.cc » ('j') | ui/events/keycodes/keyboard_code_conversion.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/keycodes/dom_us_layout_data.h

diff --git a/ui/events/keycodes/dom_us_layout_data.h b/ui/events/keycodes/dom_us_layout_data.h

index f520dc77728f04507e4cd25bf8fad8b728a3d476..243b2c5f943c7197e7a8673b8b716f8b3b6000c3 100644

--- a/ui/events/keycodes/dom_us_layout_data.h

+++ b/ui/events/keycodes/dom_us_layout_data.h

@@ -5,6 +5,8 @@

#ifndef UI_EVENTS_KEYCODES_DOM_US_LAYOUT_DATA_H_

#define UI_EVENTS_KEYCODES_DOM_US_LAYOUT_DATA_H_

+#include "ui/events/keycodes/keyboard_codes.h"

Wez 2015/07/25 23:12:26 Do you need this?

Habib Virji 2015/07/31 16:17:29 Yes, as VKEY is defined in keyboard_codes.h.

namespace ui {

// This table maps a DomCode to a printable character, assuming US layout.