Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: ui/events/keycodes/dom/dom_key.h

Issue 929053004: [KeyboardEvent] Add embedder APIs to translate between Dom |key| enum and strings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: UnitTest updated as MakeKeyboardEvent now adds a value to differentiate Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/events/keycodes/dom/dom_key.h
diff --git a/ui/events/keycodes/dom/dom_key.h b/ui/events/keycodes/dom/dom_key.h
index 25ea09209b522e649fae8c8f5fe6e6a3438974d8..11fdc097444a371e7813c267d278c776baeb11dc 100644
--- a/ui/events/keycodes/dom/dom_key.h
+++ b/ui/events/keycodes/dom/dom_key.h
@@ -7,6 +7,13 @@
namespace ui {
+// This is specific for Blink Embedded API.
+// A base of 512 (0x400) is used to differentiate between
+// DOM |Key| printable and non-printable values.
+// DOM |Key| printable value is between 0 to 0x110000 and
+// DOM |Key| non-printable value is over 0x110000.
+#define DOM_KEY_PRINT_NON_DIFF 0x110000
Wez 2015/07/25 23:12:26 See comments on Blink API impl - I don't think you
Habib Virji 2015/07/31 16:17:29 This is removed now.
+
#define DOM_KEY_MAP(key, id) id
#define DOM_KEY_MAP_DECLARATION enum class DomKey
#include "ui/events/keycodes/dom/dom_key_data.inc"

Powered by Google App Engine
This is Rietveld 408576698