Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1249)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_test.cc

Issue 928753003: Clean password_manager::ui::State (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge with master Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_test.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_test.cc b/chrome/browser/ui/passwords/manage_passwords_test.cc
index e80e18170031333b55daa209a0a81f204e0cd8b1..b80e50e70ae1113681d37b87d9bd8e5cf5aa7490 100644
--- a/chrome/browser/ui/passwords/manage_passwords_test.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_test.cc
@@ -42,7 +42,6 @@ void ManagePasswordsTest::SetupManagingPasswords() {
autofill::PasswordFormMap map;
map[kTestUsername] = test_form();
GetController()->OnPasswordAutofilled(map);
- GetController()->UpdateIconAndBubbleState(view());
}
void ManagePasswordsTest::SetupPendingPassword() {
@@ -52,11 +51,6 @@ void ManagePasswordsTest::SetupPendingPassword() {
new password_manager::PasswordFormManager(
NULL, &client, driver.AsWeakPtr(), *test_form(), false));
GetController()->OnPasswordSubmitted(test_form_manager.Pass());
-
- // Wait for the command execution triggered by the automatic popup to pop up
- // the bubble.
- content::RunAllPendingInMessageLoop();
- GetController()->UpdateIconAndBubbleState(view());
}
void ManagePasswordsTest::SetupAutomaticPassword() {
@@ -66,11 +60,6 @@ void ManagePasswordsTest::SetupAutomaticPassword() {
new password_manager::PasswordFormManager(
NULL, &client, driver.AsWeakPtr(), *test_form(), false));
GetController()->OnAutomaticPasswordSave(test_form_manager.Pass());
-
- // Wait for the command execution triggered by the automatic popup to pop up
- // the bubble.
- content::RunAllPendingInMessageLoop();
- GetController()->UpdateIconAndBubbleState(view());
}
void ManagePasswordsTest::SetupBlackistedPassword() {
@@ -78,7 +67,6 @@ void ManagePasswordsTest::SetupBlackistedPassword() {
autofill::PasswordFormMap map;
map[kTestUsername] = test_form();
GetController()->OnBlacklistBlockedAutofill(map);
- GetController()->UpdateIconAndBubbleState(view());
}
void ManagePasswordsTest::SetupChooseCredentials(
@@ -91,7 +79,6 @@ void ManagePasswordsTest::SetupChooseCredentials(
GetController()->OnChooseCredentials(
local_credentials.Pass(), federated_credentials.Pass(), origin,
base::Bind(&ManagePasswordsTest::OnChooseCredential, this));
- GetController()->UpdateIconAndBubbleState(view());
}
base::HistogramSamples* ManagePasswordsTest::GetSamples(
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_icon.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698