Issue 92873002: Revert 237623 "Default msvs_cygwin_shell to 0"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92873002: Revert 237623 "Default msvs_cygwin_shell to 0" (Closed)

Created:
7 years ago by scottmg

Modified:
7 years ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 237623 "Default msvs_cygwin_shell to 0" Broke http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/44940/steps/compile/logs/stdio#error1 remoting_copy_locales, or something. > Default msvs_cygwin_shell to 0 > > This will cause all rules that do not have msvs_cygwin_shell: 1 to run > using cmd.exe. > > R=iannucci@chromium.org > BUG=123026 > > Review URL: https://codereview.chromium.org/86703002 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237628

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	trunk/src/build/common.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r237628.