Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Issue 86703002: Default msvs_cygwin_shell to 0 (Closed)

Created:
7 years ago by scottmg
Modified:
7 years ago
Reviewers:
iannucci, Wez
CC:
chromium-reviews
Visibility:
Public.

Description

Default msvs_cygwin_shell to 0 This will cause all rules that do not have msvs_cygwin_shell: 1 to run using cmd.exe. R=iannucci@chromium.org TBR=wez@chromium.org BUG=123026 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237623 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237636

Patch Set 1 #

Patch Set 2 : with remoting opt-out for silly problem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scottmg
(Going to iterate on this on Th/Fri while the tree is quiet)
7 years ago (2013-11-25 23:51:29 UTC) #1
iannucci
lgtm, good luck. I would also give the TPM's/chrome-troopers a heads-up to keep an eye ...
7 years ago (2013-11-25 23:59:22 UTC) #2
scottmg
Committed patchset #1 manually as r237623 (presubmit successful).
7 years ago (2013-11-27 21:27:21 UTC) #3
scottmg
TBR wez for reland with remoting gyp change.
7 years ago (2013-11-27 22:49:52 UTC) #4
Wez
LGTM, but also *facepalm*
7 years ago (2013-11-27 22:52:40 UTC) #5
scottmg
Committed patchset #2 manually as r237636 (presubmit successful).
7 years ago (2013-11-27 22:52:54 UTC) #6
scottmg
7 years ago (2013-11-27 22:54:04 UTC) #7
Message was sent while issue was closed.
On 2013/11/27 22:52:40, Wez wrote:
> LGTM, but also *facepalm*

Yeah :( I'm hoping we can just switch away from VS entirely soon.

Powered by Google App Engine
This is Rietveld 408576698