Chromium Code Reviews

Unified Diff: build/toolchain.gypi

Issue 928533002: MIPS: Silence warnings and unbreak optdebug build for target. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index dfaffd05d26540fbc89208b616eeb6a4d6561cf5..e24bc205b71df0814d542fd37c8a8c23f764a399 100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -369,7 +369,12 @@
'conditions': [
['v8_target_arch==target_arch and android_webview_build==0', {
# Target built with a Mips CXX compiler.
- 'cflags': ['-EB'],
+ 'cflags': [
+ '-EB',
+ # Inhibit warning due to known issue present in the newer
+ # versions of MIPS toolchain.
+ '-Wno-error=array-bounds',
paul.l... 2015/02/13 18:26:17 I'd prefer to remove the 2 lines of comments, and
Jakob Kummerow 2015/02/14 13:01:56 Either is fine; breaking the 80-col limit for long
svetozar.janjic 2015/02/19 16:53:42 Done.
+ ],
'ldflags': ['-EB'],
'conditions': [
[ 'v8_use_mips_abi_hardfloat=="true"', {
@@ -553,7 +558,12 @@
'conditions': [
['v8_target_arch==target_arch and android_webview_build==0', {
# Target built with a Mips CXX compiler.
- 'cflags': ['-EL'],
+ 'cflags': [
+ '-EL',
+ # Inhibit warning due to known issue present in the newer
+ # versions of MIPS toolchain.
+ '-Wno-error=array-bounds',
+ ],
'ldflags': ['-EL'],
'conditions': [
[ 'v8_use_mips_abi_hardfloat=="true"', {
@@ -753,7 +763,12 @@
['_toolset=="target"', {
'conditions': [
['v8_target_arch==target_arch and android_webview_build==0', {
- 'cflags': ['-EL'],
+ 'cflags': [
+ '-EL',
+ # Inhibit warning due to known issue present in the newer
+ # versions of MIPS toolchain.
+ '-Wno-error=array-bounds',
+ ],
'ldflags': ['-EL'],
'conditions': [
[ 'v8_use_mips_abi_hardfloat=="true"', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine