Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: build/toolchain.gypi

Issue 928533002: MIPS: Silence warnings and unbreak optdebug build for target. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 the V8 project authors. All rights reserved. 1 # Copyright 2013 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 351 matching lines...) Expand 10 before | Expand all | Expand 10 after
362 'defines': [ 362 'defines': [
363 '__mips_soft_float=1' 363 '__mips_soft_float=1'
364 ] 364 ]
365 }], 365 }],
366 ], 366 ],
367 'target_conditions': [ 367 'target_conditions': [
368 ['_toolset=="target"', { 368 ['_toolset=="target"', {
369 'conditions': [ 369 'conditions': [
370 ['v8_target_arch==target_arch and android_webview_build==0', { 370 ['v8_target_arch==target_arch and android_webview_build==0', {
371 # Target built with a Mips CXX compiler. 371 # Target built with a Mips CXX compiler.
372 'cflags': ['-EB'], 372 'cflags': [
373 '-EB',
374 # Inhibit warning due to known issue present in the newer
375 # versions of MIPS toolchain.
376 '-Wno-error=array-bounds',
paul.l... 2015/02/13 18:26:17 I'd prefer to remove the 2 lines of comments, and
Jakob Kummerow 2015/02/14 13:01:56 Either is fine; breaking the 80-col limit for long
svetozar.janjic 2015/02/19 16:53:42 Done.
377 ],
373 'ldflags': ['-EB'], 378 'ldflags': ['-EB'],
374 'conditions': [ 379 'conditions': [
375 [ 'v8_use_mips_abi_hardfloat=="true"', { 380 [ 'v8_use_mips_abi_hardfloat=="true"', {
376 'cflags': ['-mhard-float'], 381 'cflags': ['-mhard-float'],
377 'ldflags': ['-mhard-float'], 382 'ldflags': ['-mhard-float'],
378 }, { 383 }, {
379 'cflags': ['-msoft-float'], 384 'cflags': ['-msoft-float'],
380 'ldflags': ['-msoft-float'], 385 'ldflags': ['-msoft-float'],
381 }], 386 }],
382 ['mips_arch_variant=="r6"', { 387 ['mips_arch_variant=="r6"', {
(...skipping 163 matching lines...) Expand 10 before | Expand all | Expand 10 after
546 'defines': [ 551 'defines': [
547 '__mips_soft_float=1' 552 '__mips_soft_float=1'
548 ], 553 ],
549 }], 554 }],
550 ], 555 ],
551 'target_conditions': [ 556 'target_conditions': [
552 ['_toolset=="target"', { 557 ['_toolset=="target"', {
553 'conditions': [ 558 'conditions': [
554 ['v8_target_arch==target_arch and android_webview_build==0', { 559 ['v8_target_arch==target_arch and android_webview_build==0', {
555 # Target built with a Mips CXX compiler. 560 # Target built with a Mips CXX compiler.
556 'cflags': ['-EL'], 561 'cflags': [
562 '-EL',
563 # Inhibit warning due to known issue present in the newer
564 # versions of MIPS toolchain.
565 '-Wno-error=array-bounds',
566 ],
557 'ldflags': ['-EL'], 567 'ldflags': ['-EL'],
558 'conditions': [ 568 'conditions': [
559 [ 'v8_use_mips_abi_hardfloat=="true"', { 569 [ 'v8_use_mips_abi_hardfloat=="true"', {
560 'cflags': ['-mhard-float'], 570 'cflags': ['-mhard-float'],
561 'ldflags': ['-mhard-float'], 571 'ldflags': ['-mhard-float'],
562 }, { 572 }, {
563 'cflags': ['-msoft-float'], 573 'cflags': ['-msoft-float'],
564 'ldflags': ['-msoft-float'], 574 'ldflags': ['-msoft-float'],
565 }], 575 }],
566 ['mips_arch_variant=="r6"', { 576 ['mips_arch_variant=="r6"', {
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
746 }, { 756 }, {
747 'defines': [ 757 'defines': [
748 '__mips_soft_float=1' 758 '__mips_soft_float=1'
749 ], 759 ],
750 }], 760 }],
751 ], 761 ],
752 'target_conditions': [ 762 'target_conditions': [
753 ['_toolset=="target"', { 763 ['_toolset=="target"', {
754 'conditions': [ 764 'conditions': [
755 ['v8_target_arch==target_arch and android_webview_build==0', { 765 ['v8_target_arch==target_arch and android_webview_build==0', {
756 'cflags': ['-EL'], 766 'cflags': [
767 '-EL',
768 # Inhibit warning due to known issue present in the newer
769 # versions of MIPS toolchain.
770 '-Wno-error=array-bounds',
771 ],
757 'ldflags': ['-EL'], 772 'ldflags': ['-EL'],
758 'conditions': [ 773 'conditions': [
759 [ 'v8_use_mips_abi_hardfloat=="true"', { 774 [ 'v8_use_mips_abi_hardfloat=="true"', {
760 'cflags': ['-mhard-float'], 775 'cflags': ['-mhard-float'],
761 'ldflags': ['-mhard-float'], 776 'ldflags': ['-mhard-float'],
762 }, { 777 }, {
763 'cflags': ['-msoft-float'], 778 'cflags': ['-msoft-float'],
764 'ldflags': ['-msoft-float'], 779 'ldflags': ['-msoft-float'],
765 }], 780 }],
766 ['mips_arch_variant=="r6"', { 781 ['mips_arch_variant=="r6"', {
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
1246 ['v8_enable_slow_dchecks==1', { 1261 ['v8_enable_slow_dchecks==1', {
1247 'defines': [ 1262 'defines': [
1248 'ENABLE_SLOW_DCHECKS', 1263 'ENABLE_SLOW_DCHECKS',
1249 ], 1264 ],
1250 }], 1265 }],
1251 ], # conditions 1266 ], # conditions
1252 }, # Release 1267 }, # Release
1253 }, # configurations 1268 }, # configurations
1254 }, # target_defaults 1269 }, # target_defaults
1255 } 1270 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698