Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 928533002: MIPS: Silence warnings and unbreak optdebug build for target. (Closed)

Created:
5 years, 10 months ago by svetozar.janjic
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Silence warnings and unbreak optdebug build for target. This is a temporary workaround for bogus array-bounds warning, due to bug in MIPS toolchain versions 4.8.2 and 4.9.2. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56273 TEST= BUG= Committed: https://crrev.com/2bf2d4d9b6f6dbcff11e02fa636253ddd4f67a72 Cr-Commit-Position: refs/heads/master@{#26756}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Comments addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M build/toolchain.gypi View 1 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
paul.l...
Please add the full gcc bug URL to the commit message. Also the wording 'falsely ...
5 years, 10 months ago (2015-02-13 18:26:17 UTC) #2
Jakob Kummerow
Owners' LGTM to un-block landing, but please get Paul's LGTM too. https://codereview.chromium.org/928533002/diff/1/build/toolchain.gypi File build/toolchain.gypi (right): ...
5 years, 10 months ago (2015-02-14 13:01:56 UTC) #3
svetozar.janjic
https://codereview.chromium.org/928533002/diff/1/build/toolchain.gypi File build/toolchain.gypi (right): https://codereview.chromium.org/928533002/diff/1/build/toolchain.gypi#newcode376 build/toolchain.gypi:376: '-Wno-error=array-bounds', On 2015/02/13 18:26:17, paul.l... wrote: > I'd prefer ...
5 years, 10 months ago (2015-02-19 16:53:43 UTC) #5
paul.l...
LGTM.
5 years, 10 months ago (2015-02-19 16:56:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928533002/20001
5 years, 10 months ago (2015-02-19 17:18:08 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-19 18:25:49 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 18:26:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2bf2d4d9b6f6dbcff11e02fa636253ddd4f67a72
Cr-Commit-Position: refs/heads/master@{#26756}

Powered by Google App Engine
This is Rietveld 408576698