Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 928513002: Revert of Reset Screen moved to ScreenContext. (Closed)

Created:
5 years, 10 months ago by jonross
Modified:
5 years, 10 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reset Screen moved to ScreenContext. (patchset #7 id:120001 of https://codereview.chromium.org/904163003/) Reason for revert: This is faling a compile on ChromeOS bots: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/77470 Original issue's description: > Reset Screen moved to ScreenContext. > > BUG=456778 > > Committed: https://crrev.com/4b77f613917020e58b31975355e4ca2347f216e2 > Cr-Commit-Position: refs/heads/master@{#316212} > > Committed: https://crrev.com/ba85904895874b5d82d78bcb499c3c5ee7388e34 > Cr-Commit-Position: refs/heads/master@{#316232} TBR=dzhioev@chromium.org,merkulova@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=456778 Committed: https://crrev.com/7a1787ede410d121a4e998cc270de8c7a191a829 Cr-Commit-Position: refs/heads/master@{#316237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+444 lines, -563 lines) Patch
D chrome/browser/chromeos/login/screens/reset_model.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/chromeos/login/screens/reset_model.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.h View 2 chunks +12 lines, -45 lines 0 comments Download
M chrome/browser/chromeos/login/screens/reset_screen.cc View 1 chunk +23 lines, -219 lines 0 comments Download
A chrome/browser/chromeos/login/screens/reset_screen_actor.h View 1 chunk +39 lines, -0 lines 0 comments Download
D chrome/browser/chromeos/login/screens/reset_view.h View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/login/ui/oobe_display.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_reset.js View 7 chunks +92 lines, -142 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.js View 2 chunks +26 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h View 2 chunks +51 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 5 chunks +189 lines, -15 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/login/display_manager.js View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jonross
Created Revert of Reset Screen moved to ScreenContext.
5 years, 10 months ago (2015-02-13 17:44:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928513002/1
5 years, 10 months ago (2015-02-13 17:45:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 17:46:25 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 17:47:00 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7a1787ede410d121a4e998cc270de8c7a191a829
Cr-Commit-Position: refs/heads/master@{#316237}

Powered by Google App Engine
This is Rietveld 408576698