Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: lib/src/core_matchers.dart

Issue 928333004: pkg/matcher: Small tweaks to improve analysis (Closed) Base URL: https://github.com/dart-lang/matcher.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/iterable_matchers.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/core_matchers.dart
diff --git a/lib/src/core_matchers.dart b/lib/src/core_matchers.dart
index a3d1f5750dcfeea6736b26a4b8073a82ee31de0a..9cb5306d32100c5d8c2a6ee99907eba8b3dc0907 100644
--- a/lib/src/core_matchers.dart
+++ b/lib/src/core_matchers.dart
@@ -302,8 +302,8 @@ class _StringEqualsMatcher extends Matcher {
int minLength = escapedItem.length < escapedValue.length
? escapedItem.length
: escapedValue.length;
- int start;
- for (start = 0; start < minLength; start++) {
+ int start = 0;
nweiz 2015/02/19 20:46:41 While you're in here, change this to "var".
kevmoo 2015/02/23 23:21:56 Done.
+ for (; start < minLength; start++) {
if (escapedValue.codeUnitAt(start) != escapedItem.codeUnitAt(start)) {
break;
}
« no previous file with comments | « no previous file | lib/src/iterable_matchers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698