pkg/matcher: Small tweaks to improve analysis

lib/src/core_matchers.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library matcher.core_matchers;
 
 import 'description.dart';
 import 'interfaces.dart';
 import 'util.dart';
 
@@ skipping 284 matching lines @@
     if (item is! String) {
       return mismatchDescription.addDescriptionOf(item).add('is not a string');
     } else {
       var buff = new StringBuffer();
       buff.write('is different.');
       var escapedItem = escape(item);
       var escapedValue = escape(_value);
       int minLength = escapedItem.length < escapedValue.length
           ? escapedItem.length
           : escapedValue.length;
-      int start;
-      for (start = 0; start < minLength; start++) {
+      int start = 0;

[nweiz, 2015/02/19 20:46:41]

While you're in here, change this to "var".

[kevmoo, 2015/02/23 23:21:56]

Done.

+      for (; start < minLength; start++) {
         if (escapedValue.codeUnitAt(start) != escapedItem.codeUnitAt(start)) {
           break;
         }
       }
       if (start == minLength) {
         if (escapedValue.length < escapedItem.length) {
           buff.write(' Both strings start the same, but the given value also'
               ' has the following trailing characters: ');
           _writeTrailing(buff, escapedItem, escapedValue.length);
         } else {
@@ skipping 327 matching lines @@
         .addDescriptionOf(matchState['feature']);
     var innerDescription = new StringDescription();
     _matcher.describeMismatch(
         matchState['feature'], innerDescription, matchState['state'], verbose);
     if (innerDescription.length > 0) {
       mismatchDescription.add(' which ').add(innerDescription.toString());
     }
     return mismatchDescription;
   }
 }