Issue 928333004: pkg/matcher: Small tweaks to improve analysis

Issue 928333004: pkg/matcher: Small tweaks to improve analysis (Closed)

Created:
5 years, 10 months ago by kevmoo

Modified:
5 years, 10 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/matcher.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Small tweaks to improve analysis R=nweiz@google.com Committed: https://github.com/dart-lang/matcher/commit/4198fe773fc993a6989a559c2271fb04fb11bb16

Patch Set 2 : nits #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	lib/src/core_matchers.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	lib/src/iterable_matchers.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

nweiz

Why doesn't DDC like these? https://codereview.chromium.org/928333004/diff/1/lib/src/core_matchers.dart File lib/src/core_matchers.dart (right): https://codereview.chromium.org/928333004/diff/1/lib/src/core_matchers.dart#newcode305 lib/src/core_matchers.dart:305: int start = 0; ...

5 years, 10 months ago (2015-02-19 20:46:41 UTC) #3

kevmoo

https://codereview.chromium.org/928333004/diff/1/lib/src/core_matchers.dart File lib/src/core_matchers.dart (right): https://codereview.chromium.org/928333004/diff/1/lib/src/core_matchers.dart#newcode305 lib/src/core_matchers.dart:305: int start = 0; On 2015/02/19 20:46:41, nweiz wrote: ...

5 years, 10 months ago (2015-02-23 23:21:56 UTC) #4

kevmoo

5 years, 10 months ago (2015-02-24 03:55:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4198fe773fc993a6989a559c2271fb04fb11bb16 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages