Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.h

Issue 928233002: IDL: Don't lose nullable flag when "preprocessing" type (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: fix compilation Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGLRenderingContextBase.h
diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.h b/Source/core/html/canvas/WebGLRenderingContextBase.h
index 7f6f01e1bf811f9f8d430340c94cfb3fe496543b..ce3d6705690ecf09ff1446249c7d3b69846a70d2 100644
--- a/Source/core/html/canvas/WebGLRenderingContextBase.h
+++ b/Source/core/html/canvas/WebGLRenderingContextBase.h
@@ -199,7 +199,7 @@ public:
ScriptValue getBufferParameter(ScriptState*, GLenum target, GLenum pname);
void getContextAttributes(Nullable<WebGLContextAttributes>&);
GLenum getError();
- PassRefPtrWillBeRawPtr<WebGLExtension> getExtension(const String& name);
Jens Widell 2015/02/16 14:33:54 This signature worked only by mistake. A method re
+ ScriptValue getExtension(ScriptState*, const String& name);
ScriptValue getFramebufferAttachmentParameter(ScriptState*, GLenum target, GLenum attachment, GLenum pname);
ScriptValue getParameter(ScriptState*, GLenum pname);
ScriptValue getProgramParameter(ScriptState*, WebGLProgram*, GLenum pname);

Powered by Google App Engine
This is Rietveld 408576698