Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 928103002: Remove some unused functions in core (Closed)

Created:
5 years, 10 months ago by Timothy Loh
Modified:
5 years, 10 months ago
Reviewers:
dstockwell, pdr.
CC:
aandrey+blink_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, Rik, dcheng, dglazkov+blink, Dominik Röttsches, dshwang, dstockwell, eae+blinkwatch, ed+blinkwatch_opera.com, Eric Willigers, jchaffraix+rendering, Justin Novosad, leviw+renderwatch, Mike Lawther (Google), mkwst+watchlist-csp_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, shans, sof, Steve Block, Timothy Loh, webcomponents-bugzilla_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove some unused functions in core Aided by callcatcher, this patch removes some unused functions in core Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190285

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : git cl try #

Total comments: 3

Patch Set 4 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -494 lines) Patch
M Source/core/animation/AnimationStack.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/AnimationStack.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/animation/animatable/AnimatableColor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/animation/animatable/AnimatableColor.cpp View 1 3 chunks +0 lines, -24 lines 0 comments Download
M Source/core/animation/animatable/AnimatableColorTest.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/animation/animatable/AnimatableDouble.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/animatable/AnimatableDouble.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/animation/animatable/AnimatableDoubleTest.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValue.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValue.cpp View 1 2 chunks +0 lines, -22 lines 0 comments Download
M Source/core/clipboard/DataObject.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/clipboard/DataObject.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M Source/core/clipboard/DataTransfer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/clipboard/DataTransfer.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/css/CSSPropertySourceData.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/css/CSSPropertySourceData.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 3 2 chunks +0 lines, -31 lines 0 comments Download
M Source/core/dom/DOMImplementation.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 3 chunks +0 lines, -18 lines 0 comments Download
M Source/core/dom/DocumentMarker.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentMarker.cpp View 2 chunks +0 lines, -18 lines 0 comments Download
M Source/core/dom/DocumentMarkerController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskRunQueue.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskRunQueue.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/editing/EditCommand.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/EditCommand.cpp View 2 chunks +0 lines, -15 lines 0 comments Download
M Source/core/events/EventListenerMap.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/events/EventListenerMap.cpp View 2 chunks +0 lines, -32 lines 0 comments Download
M Source/core/events/EventTarget.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 2 chunks +0 lines, -12 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 2 chunks +0 lines, -21 lines 0 comments Download
M Source/core/html/canvas/DataView.h View 1 chunk +0 lines, -17 lines 0 comments Download
M Source/core/html/canvas/DataView.cpp View 3 chunks +0 lines, -26 lines 0 comments Download
M Source/core/layout/style/AppliedTextDecoration.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/style/AppliedTextDecoration.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/page/DragData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/DragData.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/core/page/EventHandler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/plugins/DOMMimeTypeArray.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/plugins/DOMMimeTypeArray.cpp View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/plugins/DOMPlugin.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/plugins/DOMPlugin.cpp View 1 2 3 1 chunk +0 lines, -9 lines 0 comments Download
M Source/core/plugins/DOMPluginArray.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/plugins/DOMPluginArray.cpp View 1 2 3 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
5 years, 10 months ago (2015-02-16 03:06:28 UTC) #2
pdr.
LGTM https://codereview.chromium.org/928103002/diff/40001/Source/core/events/EventTarget.cpp File Source/core/events/EventTarget.cpp (left): https://codereview.chromium.org/928103002/diff/40001/Source/core/events/EventTarget.cpp#oldcode99 Source/core/events/EventTarget.cpp:99: UseCounter::count(executionContext(), UseCounter::AddEventListenerOneArgument); Can you remove this entry from ...
5 years, 10 months ago (2015-02-16 19:57:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928103002/60001
5 years, 10 months ago (2015-02-16 22:33:14 UTC) #6
Timothy Loh
https://codereview.chromium.org/928103002/diff/40001/Source/core/events/EventTarget.cpp File Source/core/events/EventTarget.cpp (left): https://codereview.chromium.org/928103002/diff/40001/Source/core/events/EventTarget.cpp#oldcode99 Source/core/events/EventTarget.cpp:99: UseCounter::count(executionContext(), UseCounter::AddEventListenerOneArgument); On 2015/02/16 19:57:32, pdr wrote: > Can ...
5 years, 10 months ago (2015-02-16 23:21:12 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-17 01:02:54 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190285

Powered by Google App Engine
This is Rietveld 408576698