Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 928033002: Make FrameDestructionObserver::m_frame a private. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make FrameDestructionObserver::m_frame a private. Restrict visibility over FrameDestructionObserver, notably turning m_frame into a private. This makes it slightly easier to replace FrameDestructionObserver with something LifecycleObserver-derived instead. Also includes some incidental core/plugins/ code tidyups. R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190230

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -25 lines) Patch
M Source/core/frame/FrameDestructionObserver.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/frame/FrameDestructionObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/plugins/DOMMimeType.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/plugins/DOMMimeType.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/plugins/DOMMimeTypeArray.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/plugins/DOMPlugin.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/plugins/DOMPlugin.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/plugins/DOMPluginArray.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/storage/StorageArea.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
5 years, 10 months ago (2015-02-16 08:00:45 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-16 08:11:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/928033002/1
5 years, 10 months ago (2015-02-16 08:19:21 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 08:22:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190230

Powered by Google App Engine
This is Rietveld 408576698