Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: Source/core/plugins/DOMPluginArray.cpp

Issue 928033002: Make FrameDestructionObserver::m_frame a private. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/plugins/DOMPlugin.cpp ('k') | Source/core/storage/StorageArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/plugins/DOMPluginArray.cpp
diff --git a/Source/core/plugins/DOMPluginArray.cpp b/Source/core/plugins/DOMPluginArray.cpp
index 4c711e9c6b0d3b3f024013f0ea4171d59a21005a..956898963c257cdaef85892111c8aa806d4e8f6a 100644
--- a/Source/core/plugins/DOMPluginArray.cpp
+++ b/Source/core/plugins/DOMPluginArray.cpp
@@ -54,14 +54,14 @@ PassRefPtrWillBeRawPtr<DOMPlugin> DOMPluginArray::item(unsigned index)
const Vector<PluginInfo>& plugins = data->plugins();
if (index >= plugins.size())
return nullptr;
- return DOMPlugin::create(data, m_frame, index).get();
+ return DOMPlugin::create(data, m_frame, index);
}
bool DOMPluginArray::canGetItemsForName(const AtomicString& propertyName)
{
PluginData* data = pluginData();
if (!data)
- return 0;
+ return false;
const Vector<PluginInfo>& plugins = data->plugins();
for (unsigned i = 0; i < plugins.size(); ++i) {
if (plugins[i].name == propertyName)
@@ -78,7 +78,7 @@ PassRefPtrWillBeRawPtr<DOMPlugin> DOMPluginArray::namedItem(const AtomicString&
const Vector<PluginInfo>& plugins = data->plugins();
for (unsigned i = 0; i < plugins.size(); ++i) {
if (plugins[i].name == propertyName)
- return DOMPlugin::create(data, m_frame, i).get();
+ return DOMPlugin::create(data, m_frame, i);
}
return nullptr;
}
@@ -95,10 +95,10 @@ void DOMPluginArray::refresh(bool reload)
PluginData* DOMPluginArray::pluginData() const
{
if (!m_frame)
- return 0;
+ return nullptr;
Page* page = m_frame->page();
if (!page)
- return 0;
+ return nullptr;
return page->pluginData();
}
« no previous file with comments | « Source/core/plugins/DOMPlugin.cpp ('k') | Source/core/storage/StorageArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698