Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 927943006: print_preview: remove padding above button strip on destinations dialog. (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

print_preview: remove padding above button strip on destinations dialog. R=alekseys@chromium.org BUG=459993 Committed: https://crrev.com/c58ada2301b49eb1d33b8d8a714cc3dbb061e48f Cr-Commit-Position: refs/heads/master@{#317391}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -9 lines) Patch
M chrome/browser/resources/print_preview/search/destination_list.js View 1 chunk +8 lines, -0 lines 2 comments Download
M chrome/browser/resources/print_preview/search/destination_search.css View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/search/destination_search.js View 2 chunks +2 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dan Beam
5 years, 10 months ago (2015-02-20 02:46:18 UTC) #1
Dan Beam
https://codereview.chromium.org/927943006/diff/1/chrome/browser/resources/print_preview/search/destination_list.js File chrome/browser/resources/print_preview/search/destination_list.js (right): https://codereview.chromium.org/927943006/diff/1/chrome/browser/resources/print_preview/search/destination_list.js#newcode159 chrome/browser/resources/print_preview/search/destination_list.js:159: return this.getElement().parentNode; i added this so if the DOM ...
5 years, 10 months ago (2015-02-20 19:20:44 UTC) #2
Aleksey Shlyapnikov
lgtm https://codereview.chromium.org/927943006/diff/1/chrome/browser/resources/print_preview/search/destination_list.js File chrome/browser/resources/print_preview/search/destination_list.js (right): https://codereview.chromium.org/927943006/diff/1/chrome/browser/resources/print_preview/search/destination_list.js#newcode159 chrome/browser/resources/print_preview/search/destination_list.js:159: return this.getElement().parentNode; On 2015/02/20 19:20:43, Dan Beam wrote: ...
5 years, 10 months ago (2015-02-20 19:26:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927943006/1
5 years, 10 months ago (2015-02-20 19:41:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 20:41:11 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:41:38 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c58ada2301b49eb1d33b8d8a714cc3dbb061e48f
Cr-Commit-Position: refs/heads/master@{#317391}

Powered by Google App Engine
This is Rietveld 408576698