chrome/browser/resources/print_preview/search/destination_search.js - Issue 927943006: print_preview: remove padding above button strip on destinations dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/print_preview/search/destination_search.js

Issue 927943006: print_preview: remove padding above button strip on destinations dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/print_preview/search/destination_list.js ('K') | « chrome/browser/resources/print_preview/search/destination_search.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/print_preview/search/destination_search.js

diff --git a/chrome/browser/resources/print_preview/search/destination_search.js b/chrome/browser/resources/print_preview/search/destination_search.js

index eb68c2f1ad09a4d03ea22f4b2443b13b3272a580..7233e3b8ae210f2b727edd1067133e43e928d03b 100644

--- a/chrome/browser/resources/print_preview/search/destination_search.js

+++ b/chrome/browser/resources/print_preview/search/destination_search.js

@@ -123,14 +123,6 @@ cr.define('print_preview', function() {

};

/**

- * Padding at the bottom of a destination list in pixels.

- * @type {number}

- * @const

- * @private

- */

- DestinationSearch.LIST_BOTTOM_PADDING_ = 18;

- /**

* Number of unregistered destinations that may be promoted to the top.

* @type {number}

* @const

@@ -390,8 +382,9 @@ cr.define('print_preview', function() {

var getListsTotalHeight = function(lists, counts) {

return lists.reduce(function(sum, list, index) {

+ var container = list.getContainerElement();

return sum + list.getEstimatedHeightInPixels(counts[index]) +

- DestinationSearch.LIST_BOTTOM_PADDING_;

+ parseInt(window.getComputedStyle(container).paddingBottom, 10);

}, 0);

};

var getCounts = function(lists, count) {