Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 927723003: Removing prefixMatch attribute of CacheQueryOptions- Blink Side (Closed)

Created:
5 years, 10 months ago by Paritosh Kumar
Modified:
5 years, 8 months ago
Reviewers:
Mike West, Savago, jsbell, horo
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing prefixMatch attribute of CacheQueryOptions. As this get removed in latest specs, removing it. spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#cache-query-options-dictionary PATCH 1: Chromium: https://codereview.chromium.org/941683002/ PATCH 2: Blink: [THIS PATCH] BUG=462837 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192462

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : After rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -156 lines) Patch
M LayoutTests/http/tests/serviceworker/cache-delete-expected.txt View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/cache-match-expected.txt View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/cache-delete-worker.js View 1 2 3 1 chunk +0 lines, -41 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/cache-match-worker.js View 1 2 3 1 chunk +0 lines, -98 lines 0 comments Download
M Source/modules/serviceworkers/Cache.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/CacheQueryOptions.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/CacheTest.cpp View 2 3 2 chunks +0 lines, -3 lines 0 comments Download
M public/platform/WebServiceWorkerCache.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 30 (11 generated)
Paritosh Kumar
Please have a look.
5 years, 10 months ago (2015-02-20 04:42:23 UTC) #2
Paritosh Kumar
Please have a look.
5 years, 9 months ago (2015-02-27 09:34:56 UTC) #4
jsbell
lgtm - will need owners approval for public/platform/ change Chromium side will need to land ...
5 years, 9 months ago (2015-02-27 16:45:24 UTC) #6
Mike West
Please create a bug to tie these two CLs together. It would also be nice ...
5 years, 9 months ago (2015-02-27 19:24:40 UTC) #7
horo
Please remove LayoutTests which are using "prefixMatch" in cache-match-worker.js and cache-delete-worker.js.
5 years, 9 months ago (2015-03-02 02:28:40 UTC) #8
Paritosh Kumar
On 2015/03/02 02:28:40, horo wrote: > Please remove LayoutTests which are using "prefixMatch" in cache-match-worker.js ...
5 years, 9 months ago (2015-03-02 10:38:39 UTC) #9
horo
lgtm
5 years, 9 months ago (2015-03-03 03:13:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927723003/20001
5 years, 9 months ago (2015-03-03 05:41:21 UTC) #13
Paritosh Kumar
On 2015/03/03 05:41:21, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
5 years, 9 months ago (2015-03-03 10:56:32 UTC) #15
jsbell
lgtm - what was the presubmit error, though?
5 years, 9 months ago (2015-03-06 17:02:46 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927723003/40001
5 years, 9 months ago (2015-03-06 17:03:52 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/37717)
5 years, 9 months ago (2015-03-06 17:13:22 UTC) #21
Paritosh Kumar
On 2015/03/06 17:02:46, jsbell wrote: > lgtm - what was the presubmit error, though? Thanks ...
5 years, 9 months ago (2015-03-24 12:33:59 UTC) #22
Paritosh Kumar
Updated the cl after rebase. Please have a look.
5 years, 9 months ago (2015-03-24 14:02:53 UTC) #23
jsbell
still lgtm
5 years, 9 months ago (2015-03-24 16:44:26 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927723003/60001
5 years, 9 months ago (2015-03-24 16:46:27 UTC) #27
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192462
5 years, 9 months ago (2015-03-24 19:45:18 UTC) #28
tkent
Does this remove a shipped IDL attribute?
5 years, 9 months ago (2015-03-24 22:22:05 UTC) #29
jsbell
5 years, 9 months ago (2015-03-24 22:46:23 UTC) #30
Message was sent while issue was closed.
On 2015/03/24 22:22:05, tkent wrote:
> Does this remove a shipped IDL attribute?

No - it removes an optional member of a dictionary param, and the member that
was never supported. This change is undetectable from script.

Powered by Google App Engine
This is Rietveld 408576698