Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 927653006: closure/extensions: fix some nullability issues in extension error overlay. (Closed)

Created:
5 years, 10 months ago by Dan Beam
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

closure/extensions: fix some nullability issues in extension error overlay. R=tbreisacher@chromium.org BUG=393873 Committed: https://crrev.com/c8870c6897b0a970b8475f61e5823761c1b2589a Cr-Commit-Position: refs/heads/master@{#317461}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/extensions/extension_error_overlay.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Beam
5 years, 10 months ago (2015-02-20 22:52:13 UTC) #1
Tyler Breisacher (Chromium)
lgtm
5 years, 10 months ago (2015-02-20 22:53:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927653006/1
5 years, 10 months ago (2015-02-20 22:58:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-21 00:50:56 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 00:52:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8870c6897b0a970b8475f61e5823761c1b2589a
Cr-Commit-Position: refs/heads/master@{#317461}

Powered by Google App Engine
This is Rietveld 408576698