chrome/browser/resources/extensions/extension_error_overlay.js - Issue 927653006: closure/extensions: fix some nullability issues in extension error overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_error_overlay.js

Issue 927653006: closure/extensions: fix some nullability issues in extension error overlay. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/extensions/extension_error_overlay.js

diff --git a/chrome/browser/resources/extensions/extension_error_overlay.js b/chrome/browser/resources/extensions/extension_error_overlay.js

index 2b313350ad0617db3dca0a047df0bbe5f34424be..32dcedff1cb7bf1b8034cb91dca26a625a570a0f 100644

--- a/chrome/browser/resources/extensions/extension_error_overlay.js

+++ b/chrome/browser/resources/extensions/extension_error_overlay.js

@@ -242,7 +242,8 @@ cr.define('extensions', function() {

ExtensionErrorOverlay.requestFileSource(

{extensionId: this.error_.extensionId,

message: this.error_.message,

- pathSuffix: getRelativeUrl(frame.url, this.extensionUrl_),

+ pathSuffix: getRelativeUrl(frame.url,

+ assert(this.extensionUrl_)),

lineNumber: frame.lineNumber});

}.bind(this, frame, frameNode));

« no previous file with comments | « no previous file | no next file » | no next file with comments »