Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 927653002: Revert of Insert an anonymous inline-table when inserting a table part under an inline. (patchset #… (Closed)

Created:
5 years, 10 months ago by mstensho (USE GERRIT)
Modified:
5 years, 10 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Insert an anonymous inline-table when inserting a table part under an inline. (patchset #3 id:40001 of https://codereview.chromium.org/895953003/) Reason for revert: Caused bug 458184, and more. I'll reland a new CL for this as soon as I figure out how to do so without breaking stuff. I think what needs to be fixed is to add some logic in RenderInline::addChild() or addChildBlahblah(), to drill down to the actual parent of |beforeChild|, if specified. Looks like anonymous inline-level boxes is a rather unknown concept in the engine. Also reverting the rebaselining that followed. Original issue's description: > Insert an anonymous inline-table when inserting a table part under an inline. > > The spec says that if the parent of the table part is an inline, we must wrap > it inside an inline-table instead of a table. > > Apart from giving correct rendering, this change also helps avoid establishing > (incorrect) inline continuations in some cases. > > BUG=327832, 452591, 53693, 2032 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189941 TBR=leviw@chromium.org,jchaffraix@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=327832, 452591, 53693, 2032 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+687 lines, -655 lines) Patch
M LayoutTests/fast/block/float/float-not-removed-from-pre-block-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D LayoutTests/fast/table/caption-in-inline.html View 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/table/caption-in-inline-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/table/column-in-inline.html View 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/fast/table/column-in-inline-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/fast/table/display-as-inline.html View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/table/display-as-inline-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/table/row-in-inline-block.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/table/row-in-inline-block-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/table/table-parts-in-inline.html View 1 chunk +0 lines, -41 lines 0 comments Download
D LayoutTests/fast/table/table-parts-in-inline-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/android/fast/dynamic/insert-before-table-part-in-continuation-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/tables/mozilla/bugs/bug3037-1-expected.txt View 1 chunk +0 lines, -40 lines 0 comments Download
M LayoutTests/platform/linux/fast/dynamic/insert-before-table-part-in-continuation-expected.png View Binary file 0 comments Download
M LayoutTests/platform/linux/fast/dynamic/insert-before-table-part-in-continuation-expected.txt View 5 chunks +141 lines, -92 lines 0 comments Download
M LayoutTests/platform/linux/tables/mozilla/bugs/bug3037-1-expected.txt View 1 chunk +29 lines, -21 lines 0 comments Download
A LayoutTests/platform/mac-lion/fast/dynamic/insert-before-table-part-in-continuation-expected.png View Binary file 0 comments Download
A LayoutTests/platform/mac-snowleopard/fast/dynamic/insert-before-table-part-in-continuation-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png View Binary file 0 comments Download
M LayoutTests/platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt View 5 chunks +143 lines, -95 lines 0 comments Download
M LayoutTests/platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt View 1 chunk +29 lines, -21 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/dynamic/insert-before-table-part-in-continuation-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win-xp/fast/dynamic/insert-before-table-part-in-continuation-expected.txt View 5 chunks +141 lines, -92 lines 0 comments Download
M LayoutTests/platform/win-xp/tables/mozilla/bugs/bug3037-1-expected.txt View 1 chunk +29 lines, -21 lines 0 comments Download
M LayoutTests/platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.png View Binary file 0 comments Download
M LayoutTests/platform/win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt View 5 chunks +143 lines, -95 lines 0 comments Download
M LayoutTests/platform/win/tables/mozilla/bugs/bug3037-1-expected.txt View 1 chunk +29 lines, -21 lines 0 comments Download
M Source/core/layout/LayoutTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderInline.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
mstensho (USE GERRIT)
5 years, 10 months ago (2015-02-13 19:41:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927653002/1
5 years, 10 months ago (2015-02-13 19:42:03 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 19:43:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190163

Powered by Google App Engine
This is Rietveld 408576698