Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 927543003: Add a flag to ChromeVox upload script for direct publish without interactive mode. (Closed)

Created:
5 years, 10 months ago by David Tseng
Modified:
5 years, 10 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, dtseng+watch_chromium.org, je_julie(Not used), nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a flag to ChromeVox upload script for direct publish without interactive mode. - -p or --publish will now upload and publish. - only request auth code and oauth token once each (reuse as needed for subsequent calls). - try closing some more of the httpd socket connections. Committed: https://crrev.com/6b0d8dcf9441c6458ad5e0c839f3738e765b5487 Cr-Commit-Position: refs/heads/master@{#317463}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py View 1 5 chunks +23 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py View 4 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
David Tseng
5 years, 10 months ago (2015-02-20 22:59:58 UTC) #2
dmazzoni
lgtm I like it! Don't forget I'd love to see an option to update the ...
5 years, 10 months ago (2015-02-20 23:03:01 UTC) #3
David Tseng
https://codereview.chromium.org/927543003/diff/1/chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py File chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py (right): https://codereview.chromium.org/927543003/diff/1/chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py#newcode29 chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:29: auth_code = None On 2015/02/20 23:03:01, dmazzoni wrote: > ...
5 years, 10 months ago (2015-02-20 23:34:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927543003/20001
5 years, 10 months ago (2015-02-20 23:37:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-21 00:52:12 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-21 00:53:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b0d8dcf9441c6458ad5e0c839f3738e765b5487
Cr-Commit-Position: refs/heads/master@{#317463}

Powered by Google App Engine
This is Rietveld 408576698