Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2572)

Unified Diff: chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py

Issue 927543003: Add a flag to ChromeVox upload script for direct publish without interactive mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py
diff --git a/chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py b/chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py
index 24250104ccfba185bb77ebd3c1fcd3a94fe5b5a5..9ca991ebe6050fde601f4f4f7b32e94057c6cce6 100755
--- a/chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py
+++ b/chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py
@@ -43,7 +43,9 @@ EXCLUDE_PATHS = [
def CreateOptionParser():
parser = optparse.OptionParser(description=__doc__)
- parser.usage = '%prog <extension_path> <output_path> <client_secret'
+ parser.usage = '%prog <extension_path> <client_secret>'
+ parser.add_option('-p', '--publish', action='store_true',
+ help='publish the extension')
return parser
@@ -88,11 +90,11 @@ def RunInteractivePrompt(client_secret, output_path):
chromevox_webstore_util.GetUploadStatus(client_secret).read())
elif input == 'u':
print ('Uploaded with status: %s' %
- chromevox_webstore_util.PostUpload(output_path, client_secret))
+ chromevox_webstore_util.PostUpload(output_path.name, client_secret))
elif input == 't':
print ('Published to trusted testers with status: %s' %
- chromevox_webstore_util.PostPublishTrustedTesters(
- client_secret).read())
+ chromevox_webstore_util.PostPublishTrustedTesters(
+ client_secret).read())
elif input == 'p':
print ('Published to public with status: %s' %
chromevox_webstore_util.PostPublish(client_secret).read())
@@ -102,14 +104,15 @@ def RunInteractivePrompt(client_secret, output_path):
print 'Unrecognized option: %s' % input
def main():
- _, args = CreateOptionParser().parse_args()
- if len(args) != 3:
- print 'Expected exactly three arguments'
+ options, args = CreateOptionParser().parse_args()
+ if len(args) != 2:
+ print 'Expected exactly two arguments'
+ print str(args)
sys.exit(1)
extension_path = args[0]
- output_path = args[1]
- client_secret = args[2]
+ client_secret = args[1]
+ output_path = tempfile.NamedTemporaryFile()
with ZipFile(output_path, 'w') as zip:
for root, dirs, files in os.walk(extension_path):
@@ -125,9 +128,15 @@ def main():
os.path.join(rel_path, extension_file))
manifest_file = MakeManifest()
zip.write(manifest_file.name, 'manifest.json')
- print 'Created ChromeVox zip file in %s' % output_path
+ print 'Created ChromeVox zip file in %s' % output_path.name
print 'Please run manual smoke tests before proceeding.'
- RunInteractivePrompt(client_secret, output_path)
+ if options.publish:
+ print('Uploading...%s' %
+ chromevox_webstore_util.PostUpload(output_path.name, client_secret))
+ print('publishing...%s' %
+ chromevox_webstore_util.PostPublish(client_secret).read())
+ else:
+ RunInteractivePrompt(client_secret, output_path)
if __name__ == '__main__':
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698