Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 927423002: [telemetry] Fix InspectorPage.CollectGarbage to actually collect garbage. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Fix InspectorPage.CollectGarbage to actually collect garbage. There was a typo that made this function a no-op. Performance sheriffs: this will affect memory benchmarks that rely on CollectGarbage. BUG= Committed: https://crrev.com/db3599d9652b8947b135c921b62c116e2d6a4d28 Cr-Commit-Position: refs/heads/master@{#316822}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove brackets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
ulan
PTAL
5 years, 10 months ago (2015-02-17 16:31:05 UTC) #2
Sami
Good find, lgtm. https://codereview.chromium.org/927423002/diff/1/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py File tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py (right): https://codereview.chromium.org/927423002/diff/1/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py#newcode161 tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py:161: assert('result' in res) nit: drop the ...
5 years, 10 months ago (2015-02-17 17:01:40 UTC) #3
ulan
https://codereview.chromium.org/927423002/diff/1/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py File tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py (right): https://codereview.chromium.org/927423002/diff/1/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py#newcode161 tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py:161: assert('result' in res) On 2015/02/17 17:01:39, Sami wrote: > ...
5 years, 10 months ago (2015-02-18 08:43:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927423002/20001
5 years, 10 months ago (2015-02-18 08:43:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/43619)
5 years, 10 months ago (2015-02-18 08:44:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/927423002/20001
5 years, 10 months ago (2015-02-18 13:42:41 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-18 14:37:25 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-18 14:38:01 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db3599d9652b8947b135c921b62c116e2d6a4d28
Cr-Commit-Position: refs/heads/master@{#316822}

Powered by Google App Engine
This is Rietveld 408576698