tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py - Issue 927423002: [telemetry] Fix InspectorPage.CollectGarbage to actually collect garbage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py

Issue 927423002: [telemetry] Fix InspectorPage.CollectGarbage to actually collect garbage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove brackets Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py

index b28a9863d0675e21fe734e0aacae03482e96da6c..be9a21b00a00b2cff37a6793ce0cbe3a96c89ceb 100644

--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py

+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_page.py

@@ -155,6 +155,7 @@ class InspectorPage(object):

def CollectGarbage(self, timeout=60):

request = {

- 'method': 'HeapProfiler.CollectGarbage'

+ 'method': 'HeapProfiler.collectGarbage'

}

- self._inspector_websocket.SyncRequest(request, timeout)

+ res = self._inspector_websocket.SyncRequest(request, timeout)

+ assert 'result' in res

« no previous file with comments | « no previous file | no next file » | no next file with comments »