Verify/document assumption about stack resource addresses.

runtime/vm/exceptions.cc

Index: runtime/vm/exceptions.cc
===================================================================
--- runtime/vm/exceptions.cc	(revision 43776)
+++ runtime/vm/exceptions.cc	(working copy)
@@ -281,12 +281,11 @@
 #else
   // Prepare for unwinding frames by destroying all the stack resources
   // in the previous frames.
+  StackResource::Unwind(isolate, stack_pointer);
+  // There should be some stack resources left, since we never cross the
+  // bottommost C++ frame with its handlescope, etc.
+  ASSERT(isolate->top_resource() != NULL);

[koda, 2015/02/17 21:45:50]

Added this ASSERT, which is now the first thing that fails when we run with
detect_stack_use_after_return=1 (whether it pops too much or too little depends
on the order of the malloc'ed fake stack addresses).

 
-  while (isolate->top_resource() != NULL &&
-         (reinterpret_cast<uword>(isolate->top_resource()) < stack_pointer)) {
-    isolate->top_resource()->~StackResource();
-  }
-
   // Call a stub to set up the exception object in kExceptionObjectReg,
   // to set up the stacktrace object in kStackTraceObjectReg, and to
   // continue execution at the given pc in the given frame.