Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: runtime/vm/allocation.cc

Issue 927363004: Verify/document assumption about stack resource addresses. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/allocation.cc
===================================================================
--- runtime/vm/allocation.cc (revision 43776)
+++ runtime/vm/allocation.cc (working copy)
@@ -35,4 +35,29 @@
return Allocate(size, zone);
}
+
+void StackResource::Unwind(Isolate* isolate, uword stack_pointer) {
+ while (isolate->top_resource() != NULL &&
+ (reinterpret_cast<uword>(isolate->top_resource()) < stack_pointer)) {
+ isolate->top_resource()->~StackResource();
+ }
+#if defined(DEBUG)
+ // All remaining stack resources should be below stack_pointer.
+ StackResource* current = isolate->top_resource();
+ while (current != NULL) {
+ ASSERT(reinterpret_cast<uword>(current) >= stack_pointer);
+ current = current->previous_;
+ }
+#endif // DEBUG
+}
+
+
+void StackResource::Unwind(Isolate* isolate, StackResource* new_top) {
+ StackResource* current_resource = isolate->top_resource();
+ while (current_resource != new_top) {
+ current_resource->~StackResource();
+ current_resource = isolate->top_resource();
+ }
+}
+
} // namespace dart
« no previous file with comments | « runtime/vm/allocation.h ('k') | runtime/vm/exceptions.cc » ('j') | runtime/vm/exceptions.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698